Skip to content

Nav2 PR follow up#30

Merged
arjo129 merged 3 commits into
epic/next-gen-basefrom
xiyu/followup
Jul 6, 2026
Merged

Nav2 PR follow up#30
arjo129 merged 3 commits into
epic/next-gen-basefrom
xiyu/followup

Conversation

@xiyuoh

@xiyuoh xiyuoh commented Jul 6, 2026

Copy link
Copy Markdown
Member

Some cleanup follow-up from Nav2 traffic PR outlined in #21:

  • Replace DefaultPlugins with MinimalPlugins + LogPlugin
  • Use rmf_participant_discovery for the visualizer
  • Add nav2_traffic node to demo_viz launch file

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by: Gemini 3.1 Pro

xiyuoh added 2 commits July 6, 2026 03:12
@xiyuoh
Review follow up
9b4169a 
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
@xiyuoh
Nit
a6a850c 
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
@xiyuoh xiyuoh requested a review from arjo129 July 6, 2026 03:17
@mxgrey mxgrey added this to PMC Board Jul 6, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in PMC Board Jul 6, 2026
arjo129
arjo129 approved these changes Jul 6, 2026
View reviewed changes

@arjo129 arjo129 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great for me. Have one minor knit that I probably should have highlighted earlier otherwise lgtm!

Comment thread path_server/rmf_path_server_demo/launch/demo_nav2.launch.py

@arjo129 arjo129 Jul 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knit: Lets rename this to demo_nav2.launch.py

@xiyuoh xiyuoh Jul 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0372bd8, thanks! Will merge after CI passes

@xiyuoh
Rename demo_viz launch file to demo_nav2
0372bd8 
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
@arjo129 arjo129 merged commit 03df998 into epic/next-gen-base Jul 6, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in PMC Board Jul 6, 2026
@xiyuoh xiyuoh deleted the xiyu/followup branch July 6, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjo129 arjo129 arjo129 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

PMC Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiyuoh @arjo129 @mxgrey