Movable wizard window

CMakeLists.txt

@@ -31,7 +31,7 @@ set(BIN_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
 include(${CMAKE_SOURCE_DIR}/NEXTCLOUD.cmake)
 
 set(QT_VERSION_MAJOR "6")
-set(REQUIRED_QT_VERSION "6.8.0")
+set(REQUIRED_QT_VERSION "6.10.0")
 
 # CfAPI Shell Extensions
 set( CFAPI_SHELL_EXTENSIONS_LIB_NAME CfApiShellExtensions )

src/gui/CMakeLists.txt

@@ -324,6 +324,9 @@ IF( APPLE )
     list(APPEND client_SRCS foregroundbackground_mac.mm)
     list(APPEND client_SRCS foregroundbackground_cocoa.mm)
 
+    list(APPEND client_SRCS nativetitlebar_mac.h)
+    list(APPEND client_SRCS nativetitlebar_mac.mm)
+
     if(SPARKLE_FOUND AND BUILD_UPDATER)
         # Define this, we need to check in updater.cpp
         add_definitions(-DHAVE_SPARKLE)

src/gui/folderwatcher_win.cpp

@@ -130,14 +130,6 @@ void WatcherThread::watchChanges(size_t fileNotifyBufferSize,
                 }
             }
 
-#if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)
-            // The prefix is needed for native Windows functions before Windows 10, version 1607
-            const bool hasLongPathPrefix = longPath.startsWith(QStringLiteral("\\\\?\\"));
-            if (hasLongPathPrefix)
-            {
-                longfile.remove(0, 4);
-            }
-#endif
             longfile = QDir::cleanPath(longfile);
 
             // Skip modifications of folders: One of these is triggered for changes

src/gui/nativetitlebar_mac.h

@@ -0,0 +1,31 @@
+/*
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#ifndef NATIVETITLEBAR_MAC_H
+#define NATIVETITLEBAR_MAC_H
+
+class QWindow;
+
+namespace OCC {
+
+/**
+ * @brief Style a window's native macOS title bar so it blends into the window content.
+ *
+ * Keeps the native (draggable) title bar but makes its background transparent and removes the
+ * separator hairline. For QQuickWindows the NSWindow background is matched to the window's colour
+ * (in the display's colour space) so the colour flows seamlessly through the title bar.
+ *
+ * Safe to call repeatedly — e.g. from a colorChanged signal or a changeEvent — so it survives macOS
+ * light/dark switches, which otherwise reset the styling.
+ *
+ * @param window         the top-level window to style (a QQuickWindow, or a QWidget's windowHandle()).
+ * @param hideTitleText  true to hide the title text (account wizard); false to keep it (settings).
+ * @ingroup gui
+ */
+void styleNativeTitleBar(QWindow *window, bool hideTitleText);
+
+}
+
+#endif

src/gui/nativetitlebar_mac.mm

@@ -0,0 +1,59 @@
+/*
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include "nativetitlebar_mac.h"
+
+#include <QColor>
+#include <QQuickWindow>
+#include <QWindow>
+
+#import <AppKit/AppKit.h>
+
+namespace OCC {
+
+void styleNativeTitleBar(QWindow *window, bool hideTitleText)
+{
+    if (!window) {
+        return;
+    }
+
+    const auto viewId = window->winId();
+    if (!viewId) {
+        return;
+    }
+
+    auto *const view = reinterpret_cast<NSView *>(viewId);
+    NSWindow *const nsWindow = view.window;
+    if (!nsWindow) {
+        return;
+    }
+
+    // Keep the native (draggable) title bar, but let it blend into the window: transparent
+    // background and no separator hairline. The content stays below the title bar (no full-size
+    // content view), so macOS keeps handling window dragging itself.
+    nsWindow.titlebarAppearsTransparent = YES;
+    nsWindow.titleVisibility = hideTitleText ? NSWindowTitleHidden : NSWindowTitleVisible;
+    nsWindow.titlebarSeparatorStyle = NSTitlebarSeparatorStyleNone;
+
+    // Only a QQuickWindow exposes a flat fill colour we must mirror; widget windows already carry a
+    // matching NSWindow background. Interpret it in the display's colour space rather than sRGB:
+    // Qt composites the content without colour management, so an sRGB NSColor would be re-mapped
+    // through the display profile and drift from the body on wide-gamut screens.
+    if (auto *const quickWindow = qobject_cast<QQuickWindow *>(window)) {
+        const QColor color = quickWindow->color();
+        if (color.isValid()) {
+            NSColorSpace *const colorSpace = nsWindow.screen.colorSpace ?: NSColorSpace.sRGBColorSpace;
+            const CGFloat components[] = {
+                static_cast<CGFloat>(color.redF()),
+                static_cast<CGFloat>(color.greenF()),
+                static_cast<CGFloat>(color.blueF()),
+                static_cast<CGFloat>(color.alphaF()),
+            };
+            nsWindow.backgroundColor = [NSColor colorWithColorSpace:colorSpace components:components count:4];
+        }
+    }
+}
+
+}

src/gui/owncloudsetupwizard.cpp

@@ -13,6 +13,7 @@
 
 #ifdef Q_OS_MACOS
 #include "foregroundbackground_interface.h"
+#include "nativetitlebar_mac.h"
 #endif
 
 #include <QDialog>
@@ -38,9 +39,9 @@
     }
 }
 
 static QPointer<OwncloudSetupWizard> owncloudSetupWizard = nullptr;
 
 void OwncloudSetupWizard::runWizard(QObject *obj, const char *amember, QWidget *parent, bool forceRestart)
 {
     if (!owncloudSetupWizard.isNull()) {
         if (forceRestart) {
@@ -90,7 +91,7 @@
 
 bool OwncloudSetupWizard::startQmlWizard()
 {
     auto *engine = Systray::instance()->trayEngine();
     if (!engine) {
         qCWarning(lcWizard) << "Cannot start QML account wizard without a QML engine.";
         return false;
@@ -100,7 +101,7 @@
     QQmlComponent component(engine, QStringLiteral("qrc:/qml/src/gui/wizard/qml/AccountWizardWindow.qml"));
     QVariantMap initialProperties;
     initialProperties.insert(QStringLiteral("controller"), QVariant::fromValue<QObject *>(_qmlController));
     auto *createdObject = component.createWithInitialProperties(initialProperties);
 
     if (component.isError()) {
         qCWarning(lcWizard) << "Failed to load QML account wizard:" << component.errors();
@@ -123,13 +124,8 @@
     _qmlWizardWindow->installEventFilter(fgbg);
 #endif
 
-#if defined(Q_OS_MACOS) && QT_VERSION >= QT_VERSION_CHECK(6, 9, 0)
-    _qmlWizardWindow->setFlag(Qt::ExpandedClientAreaHint, true);
-    _qmlWizardWindow->setFlag(Qt::NoTitleBarBackgroundHint, true);
-#endif
-
     connect(_qmlController, &AccountWizardController::finished, this, &OwncloudSetupWizard::finish);
     connect(_qmlWizardWindow, &QQuickWindow::visibleChanged, this, [this](bool visible) {
         if (!visible) {
             finish(QDialog::Rejected);
         }
@@ -141,10 +137,21 @@
     _qmlWizardWindow->show();
     _qmlWizardWindow->raise();
     _qmlWizardWindow->requestActivate();
+
+#ifdef Q_OS_MACOS
+    styleNativeTitleBar(_qmlWizardWindow, /*hideTitleText=*/true);
+    // Re-apply when the window colour changes (e.g. the macOS light/dark switch) so the title bar
+    // keeps matching the body. Updating it in the same synchronous step lets the system appearance
+    // cross-fade animate the title bar together with the window content.
+    connect(_qmlWizardWindow, &QQuickWindow::colorChanged, this, [this] {
+        styleNativeTitleBar(_qmlWizardWindow, /*hideTitleText=*/true);
+    });
+#endif
+
     return true;
 }
 
 void OwncloudSetupWizard::finish(int result)
 {
     if (_finished) {
         return;

src/gui/settingsdialog.cpp

@@ -1,3 +1,3 @@
 /*
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2013 ownCloud GmbH
@@ -33,6 +33,7 @@
 #include <QPainter>
 #include <QPainterPath>
 #include <QPaintEvent>
+#include <QShowEvent>
 #include <QPalette>
 #include <QQuickView>
 #include <QActionGroup>
@@ -45,6 +46,12 @@
 #include <QMouseEvent>
 #include <QWindow>
 #include <QtGlobal>
+#include <QScreen>
+#include <QGuiApplication>
+
+#ifdef Q_OS_MACOS
+#include "nativetitlebar_mac.h"
+#endif
 
 using namespace Qt::StringLiterals;
 
@@ -53,7 +60,7 @@
     #define BACKGROUND_PALETTE "alternate-base"
 #else
     // ...and "alternate-base" looks too bright on macOS only.  On Linux/Plasma either one looked fine ...
     #define BACKGROUND_PALETTE "light"
 #endif
 
 namespace {
@@ -64,7 +71,7 @@
 
     [[nodiscard]] QSize sizeHint() const override
     {
         if (const auto *widget = currentWidget()) {
             return widget->sizeHint();
         }
         return QStackedWidget::sizeHint();
@@ -72,7 +79,7 @@
 
     [[nodiscard]] QSize minimumSizeHint() const override
     {
         if (const auto *widget = currentWidget()) {
             return widget->minimumSizeHint();
         }
         return QStackedWidget::minimumSizeHint();
@@ -80,15 +87,15 @@
 
     [[nodiscard]] bool hasHeightForWidth() const override
     {
         if (const auto *widget = currentWidget()) {
             return widget->hasHeightForWidth();
         }
         return QStackedWidget::hasHeightForWidth();
     }
 
     [[nodiscard]] int heightForWidth(int width) const override
     {
         if (const auto *widget = currentWidget()) {
             return widget->hasHeightForWidth() ? widget->heightForWidth(width) : widget->sizeHint().height();
         }
         return QStackedWidget::heightForWidth(width);
@@ -103,10 +110,10 @@
     "QToolBar QToolButton:checked { background: palette(highlight); color: palette(highlighted-text); }"
 );
 
 const float buttonSizeRatio = 1.618f; // golden ratio
 constexpr auto settingsDialogDefaultWidth = 950;
 constexpr auto settingsDialogDefaultHeight = 500;
 const auto settingsNavigationIconTextSpacing = QLatin1String("  ");
 
 /** display name with two lines that is displayed in the settings
  * If width is bigger than 0, the string will be ellided so it does not exceed that width
@@ -133,35 +140,10 @@
 
 namespace OCC {
 
-class WindowDragHandle : public QWidget
-{
-public:
-    using QWidget::QWidget;
-
-protected:
-    void mousePressEvent(QMouseEvent *event) override
-    {
-        if (event->button() == Qt::LeftButton) {
-            if (const auto *window = this->window(); window && window->windowHandle()) {
-                window->windowHandle()->startSystemMove();
-                event->accept();
-                return;
-            }
-        }
-
-        QWidget::mousePressEvent(event);
-    }
-};
-
 SettingsDialog::SettingsDialog(ownCloudGui *gui, QWidget *parent)
     : QDialog(parent)
     , _gui(gui)
 {
-#if defined(Q_OS_MACOS) && QT_VERSION >= QT_VERSION_CHECK(6, 9, 0)
-    setWindowFlag(Qt::ExpandedClientAreaHint, true);
-    setWindowFlag(Qt::NoTitleBarBackgroundHint, true);
-#endif
-
     ConfigFile cfg;
 
     setupUi();
@@ -194,7 +176,7 @@
         accountAdded(account.data());
     }
 
     auto *accountSpacer = new QWidget(this);
     accountSpacer->setFixedHeight(16);
     _firstNonAccountAction = _toolBar->addWidget(accountSpacer);
 
@@ -218,12 +200,23 @@
 
     customizeStyle();
 
-    setWindowFlag(Qt::WindowContextHelpButtonHint, false);
-    setWindowFlag(Qt::Window, true);
+    // Close + minimize, but no zoom/full-screen button (full screen makes no sense for Settings).
+    setWindowFlags(Qt::Window
+        | Qt::CustomizeWindowHint
+        | Qt::WindowTitleHint
+        | Qt::WindowSystemMenuHint
+        | Qt::WindowMinimizeButtonHint
+        | Qt::WindowCloseButtonHint);
+
+    // Open centered on screen by default; restoreGeometry() overrides this when a position was saved.
+    adjustSize();
+    if (const auto *const targetScreen = QGuiApplication::primaryScreen()) {
+        move(targetScreen->availableGeometry().center() - rect().center());
+    }
     cfg.restoreGeometry(this);
 }
 
 SettingsDialog::~SettingsDialog()
 {
 }
 
@@ -232,19 +225,6 @@
     return _stack->currentWidget();
 }
 
-// close event is not being called here
-void SettingsDialog::resizeEvent(QResizeEvent *event)
-{
-    QDialog::resizeEvent(event);
-
-#if defined(Q_OS_MACOS) && QT_VERSION >= QT_VERSION_CHECK(6, 9, 0)
-    if (_windowDragHandle) {
-        _windowDragHandle->setGeometry(0, 0, width(), _windowDragHandle->height());
-        _windowDragHandle->raise();
-    }
-#endif
-}
-
 void SettingsDialog::reject()
 {
     ConfigFile cfg;
@@ -259,6 +239,20 @@
     QDialog::accept();
 }
 
+void SettingsDialog::showEvent(QShowEvent *event)
+{
+    QDialog::showEvent(event);
+
+#ifdef Q_OS_MACOS
+    // Style the title bar once the native window actually exists. Doing it earlier (e.g. from the
+    // constructor via winId()) doesn't stick, because Qt recreates the NSWindow when the dialog is
+    // shown, resetting the title-bar separator to its default.
+    if (auto *const handle = windowHandle()) {
+        styleNativeTitleBar(handle, /*hideTitleText=*/false);
+    }
+#endif
+}
+
 void SettingsDialog::changeEvent(QEvent *e)
 {
     switch (e->type()) {
@@ -269,6 +263,12 @@
 
         // Notify the other widgets (Dark-/Light-Mode switching)
         emit styleChanged();
+#ifdef Q_OS_MACOS
+        // macOS resets title-bar styling across appearance changes; re-apply it.
+        if (auto *const handle = windowHandle()) {
+            styleNativeTitleBar(handle, /*hideTitleText=*/false);
+        }
+#endif
         break;
     case QEvent::ActivationChange:
         if(isActiveWindow())
@@ -285,7 +285,7 @@
 {
     _stack->setCurrentWidget(_actionGroupWidgets.value(action));
     _stack->updateGeometry();
     if (auto *contentContainer = _stack->parentWidget()) {
         contentContainer->updateGeometry();
     }
 }
@@ -298,7 +298,7 @@
         return;
     }
     const QList<QAction *> actions = _toolBar->actions();
     for (auto *action : actions) {
         if (_actionGroupWidgets.contains(action)) {
             action->trigger();
             return;
@@ -306,14 +306,14 @@
     }
 }
 
 void SettingsDialog::setInitialAccount(AccountState *account)
 {
     _initialAccount = account;
 }
 
 void SettingsDialog::showAccount(AccountState *account)
 {
     auto *action = _actionForAccount.value(account->account().data());
     if (action) {
         action->trigger();
     }
@@ -450,9 +450,9 @@
     }
 }
 
 void SettingsDialog::addSettingsPage(const QString &iconPath, const QString &title, QWidget *settingsPage, [[maybe_unused]] bool updateChannelAware)
 {
     auto *settingsAction = createColorAwareAction(iconPath, title);
     _actionGroup->addAction(settingsAction);
     _toolBar->addAction(settingsAction);
 
@@ -461,11 +461,11 @@
     settingsPage->setObjectName(objectName);
     _stack->addWidget(settingsPage);
 
     if (auto *generalSettingsPage = qobject_cast<GeneralSettings *>(settingsPage)) {
         connect(this, &SettingsDialog::styleChanged, generalSettingsPage, &GeneralSettings::slotStyleChanged);
     } else if (auto *advancedSettingsPage = qobject_cast<AdvancedSettings *>(settingsPage)) {
         connect(this, &SettingsDialog::styleChanged, advancedSettingsPage, &AdvancedSettings::slotStyleChanged);
     } else if (auto *infoSettingsPage = qobject_cast<InfoSettings *>(settingsPage)) {
         connect(this, &SettingsDialog::styleChanged, infoSettingsPage, &InfoSettings::slotStyleChanged);
 
 #if defined(BUILD_UPDATER)
@@ -486,7 +486,7 @@
         return;
     }
 
     const QScopedValueRollback<bool> updatingStyle(_updatingStyle, true);
     _toolBar->setStyleSheet(TOOLBAR_CSS);
 
     auto separatorColor = palette().color(QPalette::Mid);
@@ -500,14 +500,14 @@
     setStyleSheet(QStringLiteral(
         "#Settings { background: palette(window); border-radius: 0; }"
 
         /* Navigation */
         "#settings_navigation_scroll { background: palette(" BACKGROUND_PALETTE "); border-radius: 12px; padding: 4px; }"
         "#settings_navigation { background: transparent; border: none; padding: 0px; }"
 
         /* Content area */
         "#settings_content, #settings_content_scroll { background: palette(window); border-radius: 12px; }"
 
         /* Panels */
         "#generalGroupBox, #notificationsGroupBox, #advancedGroupBox, #syncBehaviorGroupBox,"
         "#advancedActionsGroupBox, #aboutAndUpdatesGroupBox, #updatesGroupBox {"
         " background: palette(" BACKGROUND_PALETTE ");"
@@ -581,7 +581,7 @@
             using QToolButton::QToolButton;
 
         protected:
             void paintEvent(QPaintEvent *event) override
             {
                 Q_UNUSED(event)
 
@@ -593,7 +593,7 @@
             }
 
         private:
             void initStyleOption(QStyleOptionToolButton *option) const override
             {
                 QToolButton::initStyleOption(option);
                 if (!option->text.isEmpty()) {
@@ -603,7 +603,7 @@
             }
         };
 
         auto *btn = new SettingsNavigationButton(parent);
         QString objectName = QLatin1String("settingsdialog_toolbutton_");
         objectName += text();
         btn->setObjectName(objectName);
@@ -638,7 +638,7 @@
     setGeometry(0, 0, settingsDialogDefaultWidth, settingsDialogDefaultHeight);
     setMinimumSize(settingsDialogDefaultWidth, settingsDialogDefaultHeight);
 
     auto *mainLayout = new QHBoxLayout(this);
     mainLayout->setContentsMargins(12, 12, 12, 12);
     mainLayout->setSpacing(12);
     setLayout(mainLayout);
@@ -651,17 +651,17 @@
     _toolBar->setMinimumWidth(220);
     _toolBar->setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Minimum);
 
     auto *navigationContainer = new QWidget(this);
     navigationContainer->setObjectName("settings_navigation"_L1);
     navigationContainer->setAttribute(Qt::WA_StyledBackground);
 
     auto *navigationLayout = new QVBoxLayout(navigationContainer);
     navigationLayout->setContentsMargins(0, 0, 0, 0);
     navigationLayout->setSpacing(0);
     navigationLayout->addWidget(_toolBar);
     navigationLayout->addStretch(1);
 
     auto *navigationScroll = new QScrollArea(this);
     navigationScroll->setObjectName("settings_navigation_scroll"_L1);
     navigationScroll->setWidgetResizable(true);
     navigationScroll->setAlignment(Qt::AlignTop | Qt::AlignLeft);
@@ -674,7 +674,7 @@
     _stack = new CurrentPageSizeStackedWidget(this);
     _stack->setObjectName(u"settings_content"_s);
 
     auto *contentScroll = new QScrollArea(this);
     contentScroll->setObjectName("settings_content_scroll"_L1);
     contentScroll->setWidgetResizable(true);
     contentScroll->setAlignment(Qt::AlignTop | Qt::AlignLeft);
@@ -688,14 +688,6 @@
     mainLayout->addWidget(contentScroll);
     mainLayout->setStretch(0, 0);
     mainLayout->setStretch(1, 1);
-
-#if defined(Q_OS_MACOS) && QT_VERSION >= QT_VERSION_CHECK(6, 9, 0)
-    _windowDragHandle = new WindowDragHandle(this);
-    _windowDragHandle->setObjectName(QLatin1String("settings_window_drag_handle"));
-    _windowDragHandle->setFixedHeight(28);
-    _windowDragHandle->setGeometry(0, 0, width(), _windowDragHandle->height());
-    _windowDragHandle->raise();
-#endif
 }
 
 } // namespace OCC

src/gui/settingsdialog.h

@@ -7,7 +7,7 @@
 #ifndef SETTINGSDIALOG_H
 #define SETTINGSDIALOG_H
 
 #include <QDialog>
 #include <QStyledItemDelegate>
 
 #include "progressdispatcher.h"
@@ -61,7 +61,7 @@
     void reject() override;
     void accept() override;
     void changeEvent(QEvent *) override;
-    void resizeEvent(QResizeEvent *event) override;
+    void showEvent(QShowEvent *event) override;
 
 private slots:
     void accountAdded(OCC::AccountState *);
@@ -88,10 +88,6 @@
     QStackedWidget *_stack = nullptr;
     QAction *_firstNonAccountAction = nullptr;
 
-#if defined(Q_OS_MACOS) && QT_VERSION >= QT_VERSION_CHECK(6, 9, 0)
-    QWidget *_windowDragHandle = nullptr;
-#endif
-
     ownCloudGui *_gui;
     bool _styleUpdatePending = false;
     bool _updatingStyle = false;

src/gui/wizard/qml/AccountWizardWindow.qml

@@ -24,15 +24,19 @@ ApplicationWindow {
     LayoutMirroring.enabled: Application.layoutDirection === Qt.RightToLeft
     LayoutMirroring.childrenInherit: true
 
-    width: 500
+    width: 600
     height: compactHeight
-    minimumWidth: 480
+    minimumWidth: 600
     minimumHeight: compactHeight
     title: ""
+    // Explicit decoration set so macOS disables the green zoom/full-screen button (no maximize or
+    // full-screen hint) — full screen makes no sense for this window — while keeping a normal,
+    // draggable native title bar with close and minimize.
     flags: Qt.Window
         | Qt.CustomizeWindowHint
         | Qt.WindowTitleHint
         | Qt.WindowSystemMenuHint
+        | Qt.WindowMinimizeButtonHint
         | Qt.WindowCloseButtonHint
     color: Style.wizardWindowBackground
     palette.window: Style.wizardWindowBackground

src/gui/wizard/qml/ServerPage.qml

@@ -177,7 +177,6 @@ Item {
 
                 WizardButton {
                     primary: true
-                    Layout.preferredWidth: 76
                     enabled: !root.controller.busy
                     text: qsTr("Log in")
                     onClicked: root.controller.submitServerUrl()

src/libsync/accessmanager.cpp

@@ -33,7 +33,7 @@
     enableStrictTransportSecurityStore(true);
     setStrictTransportSecurityEnabled(true);
 
     connect(this, &QNetworkAccessManager::authenticationRequired, this, [](QNetworkReply *reply, QAuthenticator *authenticator) {
         Q_UNUSED(reply)
 
         if (authenticator->user().isEmpty()) {
@@ -72,15 +72,12 @@
     qInfo(lcAccessManager) << op << verb << newRequest.url().toString() << "has X-Request-ID" << requestId;
     newRequest.setRawHeader("X-Request-ID", requestId);
 
-#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 4)
-    // only enable HTTP2 with Qt 5.9.4 because old Qt have too many bugs (e.g. QTBUG-64359 is fixed in >= Qt 5.9.4)
     if (newRequest.url().scheme() == "https") { // Not for "http": QTBUG-61397
         // http2 seems to cause issues, as with our recommended server setup we don't support http2, disable it by default for now
         static const bool http2EnabledEnv = qEnvironmentVariableIntValue("OWNCLOUD_HTTP2_ENABLED") == 1;
 
         newRequest.setAttribute(QNetworkRequest::Http2AllowedAttribute, http2EnabledEnv);
     }
-#endif
 
     if (!newRequest.attribute(QNetworkRequest::RedirectPolicyAttribute).isValid()) {
         // We handle redirects ourselves in AbstractNetworkJob::slotFinished