Skip to content

Movable wizard window#10188

Merged
i2h3 merged 2 commits into
masterfrom
i2h3/elated-aryabhata-31ff6c
Jun 16, 2026
Merged

Movable wizard window#10188
i2h3 merged 2 commits into
masterfrom
i2h3/elated-aryabhata-31ff6c

Conversation

@i2h3

@i2h3 i2h3 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Resolves

Summary

  • Adds width to the window to reduce risk of label truncation.
  • Adds missing drag area in window on macOS.
  • Updates wizard button to have horizontal size which adapts to its label and is not fixed.

Checklist

AI (if applicable)

@i2h3 i2h3 added this to the 34.0.0 milestone Jun 15, 2026
@i2h3 i2h3 self-assigned this Jun 15, 2026
@i2h3 i2h3 requested a review from camilasan as a code owner June 15, 2026 08:05
@i2h3 i2h3 added the os: 🍎 macOS Apple macOS, formerly also known as OS X label Jun 15, 2026
@i2h3 i2h3 requested review from mgallien and nilsding as code owners June 15, 2026 08:05
@i2h3 i2h3 added the feature: ☁️ GUI System tray icon and menu. label Jun 15, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Jun 15, 2026
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Jun 15, 2026
@i2h3 i2h3 marked this pull request as draft June 15, 2026 09:25
@i2h3

i2h3 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.0

- We require at least Qt 6.10 by now.
- The REQUIRED_QT_VERSION value definition was not updated yet and outdated with 6.8.
- This renders certain conditions in code obsolete which were placed to alter behavior based on Qt version.

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/elated-aryabhata-31ff6c branch 2 times, most recently from 5c4ac95 to ca80f22 Compare June 15, 2026 19:11
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/elated-aryabhata-31ff6c branch from ca80f22 to e1d1b0d Compare June 15, 2026 20:04
@i2h3 i2h3 marked this pull request as ready for review June 15, 2026 20:05
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10188.zip

Digest: sha256:f911fe702eae856854bb277595d8e20e946a846cdfa2d756df1599c9304260a7

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
56 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@i2h3 i2h3 merged commit 71637ce into master Jun 16, 2026
39 of 40 checks passed
@i2h3 i2h3 deleted the i2h3/elated-aryabhata-31ff6c branch June 16, 2026 05:09
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: ☁️ GUI System tray icon and menu. os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Login window is not movable

1 participant