[msbuild] Resolve Content and BundleResource items using the main project's location. Fixes 23898. by rolfbjarne · Pull Request #25713 · dotnet/macios

rolfbjarne · 2026-06-17T14:24:39Z

Always compute the LogicalName for Content and BundleResource items relative to the project file (LocalMSBuildProjectFullPath) instead of the defining project file (LocalDefiningProjectFullPath). This fixes the issue where SDKs (like the Razor SDK) that add Content items from a directory far from the project would produce nonsensical paths like '../../../../../src/MyProject/file.png' that get rejected.

Fixes #23898

🤖 Pull request created by Copilot

Add a test that reproduces the issue where Content/BundleResource items defined by an SDK (like the Razor SDK) have their LogicalName computed relative to the SDK directory instead of the project directory, resulting in paths like '../../../../../src/MyProject/file.png' that get rejected. This test currently fails, demonstrating the bug described in #23898. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…s location. Fixes #23898. Always compute the LogicalName for Content and BundleResource items relative to the project file (LocalMSBuildProjectFullPath) instead of the defining project file (LocalDefiningProjectFullPath). This fixes the issue where SDKs (like the Razor SDK) that add Content items from a directory far from the project would produce nonsensical paths like '../../../../../src/MyProject/file.png' that get rejected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…10/11, opt-out for .NET 12+ Add a new MSBuild property ResolveResourceItemsRelativeToProject that controls whether Content and BundleResource items have their LogicalName computed relative to the project file (new behavior) or the defining project file (legacy behavior). - .NET 10 and .NET 11: defaults to false (opt-in) - .NET 12+: defaults to true (opt-out) The property is passed through a new IHasResolveResourceItemsRelativeToProject interface so that GetVirtualProjectPath can check the flag without changing its generic constraints. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ode paths Test with ResolveResourceItemsRelativeToProject=true (.NET 12+ default) and ResolveResourceItemsRelativeToProject=false (.NET 10/11 default) to ensure both the fixed and legacy behaviors are covered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The default 'false' applies to any TargetFrameworkVersion below 12.0, not just .NET 10 and .NET 11. Update comments and documentation to say '< .NET 12' for accuracy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…in .NET 13+ Enforce the 'permanently enabled in .NET 13+' policy with a build error if someone explicitly sets the property to false. This ensures the breaking change is enforced rather than just documented. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…test

vs-mobiletools-engineering-service2 · 2026-07-02T15:24:22Z

✅ [PR Build #2168897] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 2168897f7a23d68499ef80fdde69419023dd8cc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-07-02T15:33:50Z

✅ [PR Build #2168897] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 2168897f7a23d68499ef80fdde69419023dd8cc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-07-02T17:49:04Z

🔥 [CI Build #2168897] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

2 tests crashed, 1 tests failed, 182 tests passed.

Failures

❌ cecil tests

🔥 Failed catastrophically on VSTS: test results - cecil (no summary found).

Html Report (VSDrops) Download

❌ linker tests (tvOS)

🔥 Failed catastrophically on VSTS: test results - linker_tvos (no summary found).

Html Report (VSDrops) Download

❌ xtro tests

1 tests failed, 0 tests passed.

Failed tests

Xtro: Failed (Execution failed with exit code 1)
- Xamarin.Tests.Xtro.RunTest: ExitCode
  Assert.That(rv, Is.EqualTo (0))
  Expected: 0
  But was: 2

Html Report (VSDrops) Download

Successes

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 2168897f7a23d68499ef80fdde69419023dd8cc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-07-03T11:25:56Z

✅ [PR Build #2168897] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 2168897f7a23d68499ef80fdde69419023dd8cc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-07-03T11:39:38Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2168897f7a23d68499ef80fdde69419023dd8cc0 [PR build]

rolfbjarne added the copilot label Jun 17, 2026

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/issue-23898-test

526bba8

This comment has been minimized.

Sign in to view

rolfbjarne removed the request for review from mauroa July 2, 2026 14:18

rolfbjarne dismissed dalexsoto’s stale review via 95e0b87 July 2, 2026 14:21

rolfbjarne and others added 2 commits July 2, 2026 16:24

Merge remote-tracking branch 'origin/main' into dev/rolf/issue-23898-…

2168897

…test

This comment has been minimized.

Sign in to view

rolfbjarne enabled auto-merge (squash) July 3, 2026 11:06

dalexsoto approved these changes Jul 3, 2026

View reviewed changes

rolfbjarne merged commit 41d33d3 into main Jul 3, 2026
57 checks passed

rolfbjarne deleted the dev/rolf/issue-23898-test branch July 3, 2026 13:46

rolfbjarne mentioned this pull request Jul 6, 2026

[CI] Shared regression: Xtro.RunTest fails on main — 1 unclassified entry (Xcode 26.6) #25933

Open

Uh oh!

Conversation

rolfbjarne commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 2, 2026

✅ [PR Build #2168897] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 2, 2026

✅ [PR Build #2168897] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 2, 2026

🔥 [CI Build #2168897] Test results 🔥

Test results

Failures

❌ cecil tests

❌ linker tests (tvOS)

❌ xtro tests

Failed tests

Successes

macOS tests

Linux Build Verification

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 3, 2026

✅ [PR Build #2168897] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jul 3, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rolfbjarne commented Jun 17, 2026 •

edited

Loading