Skip to content

refactor(vertexai): remove decommisioned generativeaionvertexai_gemini_token_count_advanced region tag #10298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kef131 wants to merge 3 commits into from
Closed

refactor(vertexai): remove decommisioned generativeaionvertexai_gemini_token_count_advanced region tag #10298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ff608f
refactor: remove generativeaionvertexai_non_stream_text_basic tags fr…
Kef131 Jul 1, 2026
17b2180
chore: remove generativeaionvertexai_gemini_generate_from_text_input …
Kef131 Jul 1, 2026
5ec692e
refactor: remove unused tag from GetMediaTokenCount.java
Kef131 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions vertexai/snippets/src/main/java/vertexai/gemini/GetMediaTokenCount.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package vertexai.gemini;

// [START generativeaionvertexai_gemini_token_count_advanced]
import com.google.cloud.vertexai.VertexAI;
import com.google.cloud.vertexai.api.Content;
import com.google.cloud.vertexai.api.CountTokensResponse;
Expand Down Expand Up @@ -58,4 +57,3 @@ public static int getMediaTokenCount(String projectId, String location, String m
}
}
}
// [END generativeaionvertexai_gemini_token_count_advanced]
4 changes: 1 addition & 3 deletions vertexai/snippets/src/main/java/vertexai/gemini/QuestionAnswer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package vertexai.gemini;

// [START generativeaionvertexai_non_stream_text_basic]
import com.google.cloud.vertexai.VertexAI;

@gemini-code-assist gemini-code-assist Bot Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It appears that the region tag generativeaionvertexai_non_stream_text_basic was accidentally removed. The PR description only mentions decommissioning generativeaionvertexai_gemini_token_count_advanced. Removing this active region tag will break the Java code snippet on the public documentation page 'Generate Text With a Generative Model'. Please restore this tag.

Suggested change
import com.google.cloud.vertexai.VertexAI;
// [START generativeaionvertexai_non_stream_text_basic]
import com.google.cloud.vertexai.VertexAI;

import com.google.cloud.vertexai.api.GenerateContentResponse;
import com.google.cloud.vertexai.generativeai.GenerativeModel;
Expand Down Expand Up @@ -49,5 +48,4 @@ public static String simpleQuestion(String projectId, String location, String mo
return output;
}
}
}
// [END generativeaionvertexai_non_stream_text_basic]
}

@gemini-code-assist gemini-code-assist Bot Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Please restore the corresponding [END ...] region tag to avoid breaking the documentation page.

Suggested change
}
}
// [END generativeaionvertexai_non_stream_text_basic]

4 changes: 1 addition & 3 deletions vertexai/snippets/src/main/java/vertexai/gemini/TextInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package vertexai.gemini;

// [START generativeaionvertexai_gemini_generate_from_text_input]
import com.google.cloud.vertexai.VertexAI;

@gemini-code-assist gemini-code-assist Bot Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It appears that the region tag generativeaionvertexai_gemini_generate_from_text_input was accidentally removed. The PR description only mentions decommissioning generativeaionvertexai_gemini_token_count_advanced. Removing this active region tag will break the Java code snippet on the public documentation page 'Generate text from text-only input'. Please restore this tag.

Suggested change
import com.google.cloud.vertexai.VertexAI;
// [START generativeaionvertexai_gemini_generate_from_text_input]
import com.google.cloud.vertexai.VertexAI;

import com.google.cloud.vertexai.api.GenerateContentResponse;
import com.google.cloud.vertexai.generativeai.GenerativeModel;
Expand Down Expand Up @@ -52,5 +51,4 @@ public static String textInput(
return output;
}
}
}
// [END generativeaionvertexai_gemini_generate_from_text_input]
}

@gemini-code-assist gemini-code-assist Bot Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Please restore the corresponding [END ...] region tag to avoid breaking the documentation page.

Suggested change
}
}
// [END generativeaionvertexai_gemini_generate_from_text_input]