refactor(vertexai): remove decommisioned generativeaionvertexai_gemini_token_count_advanced region tag#10298
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes documentation region tags from several Java snippet files. While decommissioning the token count snippet is expected, the reviewer notes that active region tags in QuestionAnswer.java and TextInput.java were accidentally removed as well. Restoring these tags is necessary to prevent breaking the associated public documentation pages.
| package vertexai.gemini; | ||
|
|
||
| // [START generativeaionvertexai_non_stream_text_basic] | ||
| import com.google.cloud.vertexai.VertexAI; |
There was a problem hiding this comment.
It appears that the region tag generativeaionvertexai_non_stream_text_basic was accidentally removed. The PR description only mentions decommissioning generativeaionvertexai_gemini_token_count_advanced. Removing this active region tag will break the Java code snippet on the public documentation page 'Generate Text With a Generative Model'. Please restore this tag.
| import com.google.cloud.vertexai.VertexAI; | |
| // [START generativeaionvertexai_non_stream_text_basic] | |
| import com.google.cloud.vertexai.VertexAI; |
| } | ||
| } | ||
| // [END generativeaionvertexai_non_stream_text_basic] | ||
| } No newline at end of file |
| package vertexai.gemini; | ||
|
|
||
| // [START generativeaionvertexai_gemini_generate_from_text_input] | ||
| import com.google.cloud.vertexai.VertexAI; |
There was a problem hiding this comment.
It appears that the region tag generativeaionvertexai_gemini_generate_from_text_input was accidentally removed. The PR description only mentions decommissioning generativeaionvertexai_gemini_token_count_advanced. Removing this active region tag will break the Java code snippet on the public documentation page 'Generate text from text-only input'. Please restore this tag.
| import com.google.cloud.vertexai.VertexAI; | |
| // [START generativeaionvertexai_gemini_generate_from_text_input] | |
| import com.google.cloud.vertexai.VertexAI; |
| } | ||
| } | ||
| // [END generativeaionvertexai_gemini_generate_from_text_input] | ||
| } No newline at end of file |
Description
Fixes #
b/530681617
Region tag
generativeaionvertexai_gemini_token_count_advancedshows no reference in devsiteChecklist
Testing
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory onlyCompliance & Style
pom.xmlparent set to latestshared-configurationPost-Approval Actions