Skip to content

fix: allow add_memory() to work when topic_segment=False #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
li5435945-ship-it wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow add_memory() to work when topic_segment=False #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/lightmem/memory/lightmem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,17 +296,12 @@ def add_memory(
self.logger.info(f"[{call_id}] Pre-compression disabled, using normalized messages")

if not self.config.topic_segment:
# TODO:
self.logger.info(f"[{call_id}] Topic segmentation disabled, returning emitted messages")
return {
"triggered": True,
"cut_index": len(msgs),
"boundaries": [0, len(msgs)],
"emitted_messages": msgs,
"carryover_size": 0,
}

all_segments = self.senmem_buffer_manager.add_messages(compressed_messages, self.segmenter, self.text_embedder)
# When topic segmentation is disabled, treat all messages as a single segment
# and proceed with the extraction pipeline directly
self.logger.info(f"[{call_id}] Topic segmentation disabled, treating all messages as single segment")
all_segments = [compressed_messages]
else:
all_segments = self.senmem_buffer_manager.add_messages(compressed_messages, self.segmenter, self.text_embedder)

if force_segment:
all_segments = self.senmem_buffer_manager.cut_with_segmenter(self.segmenter, self.text_embedder, force_segment)
Expand Down