Skip to content

Update package.json: modify postinstall script #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sudodoki wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update package.json: modify postinstall script #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"url": "https://github.com/matsko/YOM-AngularJS-Testing-Article"
},
"scripts": {
"postinstall": "./node_modules/.bin/bower install"
"postinstall": "bower install"

@ghost ghost Jul 18, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change results in the following messages "bower install" not found exit status 127

@sudodoki sudodoki Jul 18, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your version of npm (npm -v)? Try updating npm (npm install -g npm), because npm by defaults adds ./node_modules/.bin folder to $PATH, so npm-scripts can use executables without this dance, which comes out to not work on windows (wrong separator).

@ghost ghost Jul 18, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am js noob so bare with me if i say something completely idiotic, npm -v returned 1.4.14, npm was installed with the nodejs package, which i installed from this repo ppa:chris-lea/node.js. And by the way i am using a vagrant box for my dev environnement, pretty this might have an influence.

@sudodoki sudodoki Jul 18, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version looks good. But this worked for me previously. Will check
everything again as soon as I get to my machine.

Sorry for tyops, I'm doing this via phone.
18.07.2014 10:13 пользователь "ExuperO" notifications@github.com написал:

In package.json:

@@ -6,7 +6,7 @@
"url": "https://github.com/matsko/YOM-AngularJS-Testing-Article"
},
"scripts": {

  • "postinstall": "./node_modules/.bin/bower install"
  • "postinstall": "bower install"

I am js noob so bare with me if i say something completely idiotic, npm -v
returned 1.4.14, npm was installed with nodejs packaged, which i installed
from this repo ppa:chris-lea/node.js.

—
Reply to this email directly or view it on GitHub
https://github.com/yearofmoo-articles/AngularJS-Testing-Article/pull/31/files#r15098940
.

@ghost ghost Jul 18, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help

@sudodoki sudodoki Jul 18, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, today I'm getting an issue with bootstrap.css not found. 😢

@sudodoki sudodoki Jul 18, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, actually, that was an issue with my bower using the different registry. But still, my bower installed 1.2.8 fails with 'Arguments to path.join must be strings', which means bower version in package.json should be bumped (known issue that came up last week, I believe). See bower/bower#1404.

},
"homepage": "https://github.com/yearofmoo/YOM-AngularJS-Testing-Article",
"devDependencies": {
Expand Down