fix: detect externally installed ACP agents#286
Open
H1d3rOne wants to merge 1 commit into
Open
Conversation
Expand agent detection beyond Codeg-managed install records: resolve npm shims/package metadata, detect upstream Claude/Codex CLIs separately from ACP adapters, accept system binaries including OpenCode CLI app-bundle paths, and align uvx/Hermes readiness with system CLI fallbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--versionoutput, usingunknownwhen launchable but version is not provableuvx/ systemhermesfallbacks so Settings, preflight, and connect gating agreeVerification
cargo checkcargo clippy --all-targets --features test-utils -- -D warningscargo test --features test-utils commands::acp::tests::pnpm eslint .pnpm vitest run src/components/settings/acp-agent-settings.test.tsxgit diff --check