test(gpt55): agentic review @beta.14 — openai.gpt-5.5#17
Closed
wezell wants to merge 1 commit into
Closed
Conversation
dotCMS#36279) Content Drive's upload dialog lets users pick Asset vs File, which are semantically base types. Previously only DOTASSET could be resolved from a base type on the backend, so firing the NEW workflow action with baseType: FILEASSET failed with "content type or base type is not set or is invalid". This adds the missing FILEASSET resolution and switches the frontend to send the base type. Backend: - Extract the dotAsset mime-matching algorithm into a reusable BaseTypeMimeTypeMatcher (parameterized by base type + binary field var); DotAssetAPIImpl.tryMatch now delegates to it (DOTASSET behavior unchanged). - Move DotAssetBaseTypeToContentTypeStrategyImpl out of the resolver into its own class and add FileAssetBaseTypeToContentTypeStrategyImpl, which mime-matches FILEASSET content types and falls back to the default FileAsset. - Register both strategies; fix BaseTypeToContentTypeStrategyResolver.subscribe which ignored its baseContentType arg and always registered under DOTASSET. Frontend: - Revert uploadDotAsset to its original 2-arg form; add uploadFileByBaseType (DotUploadFileService) and newContentletByBaseType (DotWorkflowActionsFireService) which send baseType instead of contentType. - Content Drive now emits DOTASSET/FILEASSET and routes uploads through the new method; root-level uploads carry the current site identifier so they land on the browsed site, not the default host. Tests: resolver unit test (subscribe regression + FILEASSET registration), FileAsset strategy integration test, and frontend specs for the new methods, base-type selection, and current-site root upload. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🤖 dotBot Review (Bedrock Mantle)No issues found. openai.gpt-5.5 · Run: #28255110223 · tokens: in: 19307 · out: 1571 (reasoning: 1552) · total: 20878 · est. ~$0.0398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean single-model e2e at @v3.3.0-beta.14 (gather-step pipefail fix; cost footer + budget clamp + tool diagnostics). Model:
openai.gpt-5.5— Bedrock Mantle. Reviewed diff = only the dotCMS#36317 change. Throwaway.