fix(thresholds): reorder write operations to avoid firmware rejection…#9
Open
MatiM72737 wants to merge 1 commit into
Open
fix(thresholds): reorder write operations to avoid firmware rejection…#9MatiM72737 wants to merge 1 commit into
MatiM72737 wants to merge 1 commit into
Conversation
… when lowering stop threshold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Invalid argument" when setting battery charge thresholds
The firmware rejects writes to
charge_control_end_thresholdif it would temporarily make start ≥ stop.Solution
new_stop < current_start), write new start first, then new stopTested on
t495s (r5 3500U)6.18.9.zen1-2