Skip to content

Add sample for stand alone nexus operations#456

Merged
Quinn-With-Two-Ns merged 3 commits into
temporalio:mainfrom
Quinn-With-Two-Ns:stand-alone-nexus-operations
Jul 9, 2026
Merged

Add sample for stand alone nexus operations#456
Quinn-With-Two-Ns merged 3 commits into
temporalio:mainfrom
Quinn-With-Two-Ns:stand-alone-nexus-operations

Conversation

@Quinn-With-Two-Ns

Copy link
Copy Markdown
Contributor

Sample for stand alone nexus operations

Comment thread nexus-standalone-operations/handler_test.go Outdated
Comment thread nexus-standalone-operations/handler_test.go Outdated
Comment thread nexus-standalone-operations/handler_test.go Outdated
Comment thread nexus-standalone-operations/handler_test.go Outdated
Comment thread nexus-standalone-operations/handler_test.go Outdated
require.Eventually(t, func() bool {
var execErr error
handle, execErr = nexusClient.ExecuteOperation(ctx, opName, input, options)
return execErr == nil

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the need to retry for tests before we launch SANO. It's going to be annoying to use.
You should also only filter out not found errors here.

@Evanthx Evanthx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking some questions, not sure how many are just me being new still!

Comment thread go.mod Outdated

replace github.com/cactus/go-statsd-client => github.com/cactus/go-statsd-client/v5 v5.0.0

replace go.temporal.io/sdk => /Users/quinnklassen/Documents/Code/sdk-go

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you said this wasn't ready for checkin, but figured it was worth pointing out these two replace commands!

Comment thread nexus-standalone-operations/README.md Outdated
Comment thread nexus-standalone-operations/README.md Outdated
Comment thread nexus-standalone-operations/README.md Outdated
Comment thread nexus-standalone-operations/README.md Outdated
Comment thread nexus-standalone-operations/starter/main.go
Comment thread nexus-standalone-operations/worker/main.go
Comment thread nexus-standalone-operations/starter/main.go
Comment thread nexus-standalone-operations/starter/main.go Outdated

@VegetarianOrc VegetarianOrc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread nexus-standalone-operations/handler_test.go Outdated
@chrsmith chrsmith removed their assignment May 26, 2026
@jsundai

jsundai commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@Quinn-With-Two-Ns Is this sample ready to be merged?

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the stand-alone-nexus-operations branch from ab5922d to 974f5fb Compare July 7, 2026 22:41
@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review July 8, 2026 17:16
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner July 8, 2026 17:16
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 06744a3 into temporalio:main Jul 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants