fix: update bitkit core#609
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9854330e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requirement = { | ||
| kind = exactVersion; | ||
| version = 0.1.66; | ||
| version = 0.1.75; |
There was a problem hiding this comment.
Wire core LNURL invoice validation into pay flow
For LNURL-pay requests, this bump only updates the package; the app still fetches invoices through LnurlHelper.fetchLnurlInvoice (Bitkit/Utilities/Lnurl.swift:130-149) from both LnurlPayConfirm and SendQuickpay, and those call sites then pass sats: nil to sendWithTimeout, so a callback that returns a BOLT11 for a different amount is still paid at the invoice's amount. Please route these call sites through the new bitkit-core v0.1.75 validation or validate amount/metadata locally so the dependency bump actually protects LNURL-pay users.
Useful? React with 👍 / 👎.
|
Closing in favor of a release-branch PR. |
Description
This PR updates Bitkit Core to v0.1.75 for LNURL-pay payment handling.
Linked Issues/Tasks
N/A
Screenshot / Video
N/A
QA Notes
Manual Tests
N/A
Automated Checks
xcodebuild -resolvePackageDependencies -project Bitkit.xcodeproj -scheme Bitkit