Skip to content

fix: update bitkit core#609

Closed
ovitrif wants to merge 2 commits into
masterfrom
fix/lnurl-pay-core-0.1.75
Closed

fix: update bitkit core#609
ovitrif wants to merge 2 commits into
masterfrom
fix/lnurl-pay-core-0.1.75

Conversation

@ovitrif

@ovitrif ovitrif commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR updates Bitkit Core to v0.1.75 for LNURL-pay payment handling.

Linked Issues/Tasks

N/A

Screenshot / Video

N/A

QA Notes

Manual Tests

N/A

Automated Checks

  • xcodebuild -resolvePackageDependencies -project Bitkit.xcodeproj -scheme Bitkit

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown

Greptile Summary

This PR bumps the bitkit-core Swift package dependency from v0.1.66 to v0.1.75 to pick up improved LNURL-pay payment handling, and adds a matching changelog fragment.

  • project.pbxproj updated the exactVersion requirement for bitkit-core from 0.1.660.1.75.
  • Package.resolved updated the pinned revision hash and version string consistently with the requirement change.

Confidence Score: 5/5

Safe to merge — a straightforward dependency pin bump with no logic changes in the iOS app itself.

The only code changes are the version string and revision hash for bitkit-core in the two Xcode dependency files, plus a one-line changelog entry. Both files are consistent with each other (version 0.1.75 / revision 496c084), the bump uses an exactVersion pin so there is no floating-range risk, and the PR description notes that package resolution was verified with xcodebuild.

No files require special attention.

Important Files Changed

Filename Overview
Bitkit.xcodeproj/project.pbxproj Bumps bitkit-core exact version requirement from 0.1.66 to 0.1.75; no other changes.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Updates resolved revision hash and version for bitkit-core from 0.1.66/99ffc3b to 0.1.75/496c084; consistent with the pbxproj change.
changelog.d/hotfix/lnurl-pay-core.fixed.md New changelog fragment noting improved LNURL-pay payment handling.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant App as Bitkit iOS App
    participant SPM as Swift Package Manager
    participant Core as bitkit-core (GitHub)

    App->>SPM: Resolve dependencies (project.pbxproj)
    SPM->>Core: "Fetch exactVersion = 0.1.75"
    Core-->>SPM: "Return package @ revision 496c084"
    SPM-->>App: Package.resolved locked (0.1.75 / 496c084)
    App->>Core: LNURL-pay payment handling (v0.1.75)
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant App as Bitkit iOS App
    participant SPM as Swift Package Manager
    participant Core as bitkit-core (GitHub)

    App->>SPM: Resolve dependencies (project.pbxproj)
    SPM->>Core: "Fetch exactVersion = 0.1.75"
    Core-->>SPM: "Return package @ revision 496c084"
    SPM-->>App: Package.resolved locked (0.1.75 / 496c084)
    App->>Core: LNURL-pay payment handling (v0.1.75)
Loading

Reviews (1): Last reviewed commit: "chore: rename changelog fragment" | Re-trigger Greptile

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9854330e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

requirement = {
kind = exactVersion;
version = 0.1.66;
version = 0.1.75;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire core LNURL invoice validation into pay flow

For LNURL-pay requests, this bump only updates the package; the app still fetches invoices through LnurlHelper.fetchLnurlInvoice (Bitkit/Utilities/Lnurl.swift:130-149) from both LnurlPayConfirm and SendQuickpay, and those call sites then pass sats: nil to sendWithTimeout, so a callback that returns a BOLT11 for a different amount is still paid at the invoice's amount. Please route these call sites through the new bitkit-core v0.1.75 validation or validate amount/metadata locally so the dependency bump actually protects LNURL-pay users.

Useful? React with 👍 / 👎.

@ovitrif

ovitrif commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Closing in favor of a release-branch PR.

@ovitrif ovitrif closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant