refactor: use core hw activities#1044
Draft
ovitrif wants to merge 8 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1029
Refs #998
Status
Blocked by upstream Bitkit Core work:
walletIdto v2 activity models instead of changing the current v1 activity schema.This PR should stay open as the Android integration branch for hardware-wallet activities, but it should not merge until the corrected Bitkit Core model/versioning and backup migration work is available and Android is rebased onto that release.
Description
This PR refactors hardware-wallet activity handling to use Bitkit Core's wallet-scoped activity model instead of keeping Trezor transactions as separate in-memory watch-only entries.
This PR:
bitkit-coreto0.3.4and threads wallet ids through activity reads, tags, transaction details, deletion, pre-activity metadata, and seen-state helpers.Out of scope for #1030:
Preview
QA Notes
Manual Tests
regression:normal on-chain/LN activity → Activity Detail → tags and Explore: behavior matchesmaster.Automated Checks
HwWalletRepoTest.ktcovers active-watcher ownership, Core persistence ordering, duplicate address-type aggregation, wallet-id watcher restarts, and removal purge failures.TrezorRepoTest.kt,ActivityRepoTest.kt,ActivityDetailViewModelTest.kt,ActivityListViewModelTest.kt,AppViewModelSendFlowTest.kt,NotifyPaymentReceivedHandlerTest.kt, andPreActivityMetadataRepoTest.ktcover deterministic hardware wallet id derivation, scoped activity lookup/navigation, hardware tag/filter behavior, sheet detail routing, and nullable wallet-scope defaults.activity-blue-icons.xmlcovers unified hardware activity list/tab behavior;activity-detail-hw-tags.xmlcovers hardware tags and Explore inputs/outputs.just compile,just test, andjust lintpassed.