Skip to content

Christopher 07 02 2026#1399

Open
wlpotter wants to merge 8 commits into
2026-tei-workshop-basefrom
Christopher_07_02_2026
Open

Christopher 07 02 2026#1399
wlpotter wants to merge 8 commits into
2026-tei-workshop-basefrom
Christopher_07_02_2026

Conversation

@wlpotter

@wlpotter wlpotter commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Creating PR to give feedback to workshop participants

@wlpotter wlpotter left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShakespeareYang see the in-line comments for specific feedback. Let me know if I can clarify any of my notes. Great work on this!

Comment thread data/works/tei/5502.xml Outdated
<text>
<body>
<bibl xml:id="work-5502" type="lawd:ConceptualWork">
<title xml:id="name5502-1" xml:lang="en" srophe:tags="#syriaca-headword">The Apology of Aristides</title>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titles need either a source attribute pointing to a bibl xml:id, or a resp="http://syriaca.org"

Comment thread data/works/tei/5502.xml Outdated
<body>
<bibl xml:id="work-5502" type="lawd:ConceptualWork">
<title xml:id="name5502-1" xml:lang="en" srophe:tags="#syriaca-headword">The Apology of Aristides</title>
<author ref="http://syriaca.org/person/341">Aristides <foreign xml:lang="syr">ܐܪܣܛܕܝܣ</foreign></author>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authors also need a resp or source

Comment thread data/works/tei/5502.xml Outdated
<author ref="http://syriaca.org/person/341">Aristides <foreign xml:lang="syr">ܐܪܣܛܕܝܣ</foreign></author>
<idno type="URI">http://syriaca.org/work/5502</idno>
<textLang mainLang="syr"/>
<date>2nd century</date>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! You can also add attributes, notBefore and notAfter, to give the terminus dates for this range, e.g. "0100" and "0200"

Comment thread data/works/tei/5502.xml Outdated
<date>2nd century</date>
<noteGrp type="abstract">
<desc xml:lang="en">Abstract</desc>
<!-- Is there a way to add a second source for the abstract? I want to add the fact that it is one of the earliest Christian Apologies, which is mentioned in bib5502-1, but not bib5502-2. Are these composite descriptions desired?--><note corresp="http://syriaca.org/nhsl" xml:id="abstract-en-5502" source="#bib5502-2" xml:lang="en" type="abstract" resp="http://syriaca.org">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can add multiple sources by putting a space between them: source="#bib5502-1 #bib5502-2".

Also note that if you use a source, you should not also have a resp attribute (only use resp if it's unsourced)

Comment thread data/works/tei/5502.xml
<noteGrp type="abstract">
<desc xml:lang="en">Abstract</desc>
<!-- Is there a way to add a second source for the abstract? I want to add the fact that it is one of the earliest Christian Apologies, which is mentioned in bib5502-1, but not bib5502-2. Are these composite descriptions desired?--><note corresp="http://syriaca.org/nhsl" xml:id="abstract-en-5502" source="#bib5502-2" xml:lang="en" type="abstract" resp="http://syriaca.org">
An early Apology for Christianity originally written in Greek and addressed to an unnamed emperor (CPG 1062).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's excellent that the abstract includes the CPG number. We like to capture these kinds of reference numbers (CPG, BHO, etc.) when possible. If you'd like, you can include it as an idno above under the work URI (i.e., under line 93).

It would look like: <idno type="number" subtype="CPG">1062</idno>. See https://syriaca.org/documentation/schemas/syriacaWorks.compiled.html#referenceNumbers for more on this

Comment thread data/works/tei/5502.xml Outdated
<listBibl type="modernTranslations">
<head>Modern Translations</head>
<desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5502-1" resp="http://syriaca.org" type="syriaca:ModernTranslation">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine, but not necessary, to include a resp on bibls

Comment thread data/works/tei/5502.xml Outdated
<head>Modern Translations</head>
<desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl xml:id="bib5502-1" resp="http://syriaca.org" type="syriaca:ModernTranslation">
<title>The Apology of Aristides On Behalf of the Christians. From a Syriac MS. Preserved on Mount Sinai.</title>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titles in listBibl/bibl should have an xml:lang attribute

Comment thread data/works/tei/5502.xml Outdated
<textLang mainLang="de"/>
</bibl>
</listBibl>
<listBibl>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to delete unused/empty listBibls from the template

Comment thread data/works/tei/5502.xml Outdated
<head>Secondary Literature</head>
<desc xml:lang="en">This is not a comprehensive list of secondary literature related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc>
<bibl type="lawd:Citation" xml:id="bib5502-2">
<!--not quite sure what level="a" means --><title level="a" xml:lang="en">Aristides of Athens</title>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the level attribute refers to whether it is an 'analytic' (i.e., journal article or book chapter), 'monographic' (level=m), or 'serial' (level=s, i.e. a book series or journal title). It's not necessary to include for these titles, especially since you have the CBSS URI in the ptr

Comment thread data/works/tei/5502.xml Outdated
<bibl type="lawd:Citation" xml:id="bib5502-2">
<!--not quite sure what level="a" means --><title level="a" xml:lang="en">Aristides of Athens</title>
<ptr target="http://syriaca.org/cbss/YIEGKM3S"/>
<citedRange unit="entry">31-32</citedRange>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'entry' or 'p' for the unit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants