Christopher 07 02 2026#1399
Conversation
wlpotter
left a comment
There was a problem hiding this comment.
@ShakespeareYang see the in-line comments for specific feedback. Let me know if I can clarify any of my notes. Great work on this!
| <text> | ||
| <body> | ||
| <bibl xml:id="work-5502" type="lawd:ConceptualWork"> | ||
| <title xml:id="name5502-1" xml:lang="en" srophe:tags="#syriaca-headword">The Apology of Aristides</title> |
There was a problem hiding this comment.
Titles need either a source attribute pointing to a bibl xml:id, or a resp="http://syriaca.org"
| <body> | ||
| <bibl xml:id="work-5502" type="lawd:ConceptualWork"> | ||
| <title xml:id="name5502-1" xml:lang="en" srophe:tags="#syriaca-headword">The Apology of Aristides</title> | ||
| <author ref="http://syriaca.org/person/341">Aristides <foreign xml:lang="syr">ܐܪܣܛܕܝܣ</foreign></author> |
There was a problem hiding this comment.
authors also need a resp or source
| <author ref="http://syriaca.org/person/341">Aristides <foreign xml:lang="syr">ܐܪܣܛܕܝܣ</foreign></author> | ||
| <idno type="URI">http://syriaca.org/work/5502</idno> | ||
| <textLang mainLang="syr"/> | ||
| <date>2nd century</date> |
There was a problem hiding this comment.
Great! You can also add attributes, notBefore and notAfter, to give the terminus dates for this range, e.g. "0100" and "0200"
| <date>2nd century</date> | ||
| <noteGrp type="abstract"> | ||
| <desc xml:lang="en">Abstract</desc> | ||
| <!-- Is there a way to add a second source for the abstract? I want to add the fact that it is one of the earliest Christian Apologies, which is mentioned in bib5502-1, but not bib5502-2. Are these composite descriptions desired?--><note corresp="http://syriaca.org/nhsl" xml:id="abstract-en-5502" source="#bib5502-2" xml:lang="en" type="abstract" resp="http://syriaca.org"> |
There was a problem hiding this comment.
Yes, you can add multiple sources by putting a space between them: source="#bib5502-1 #bib5502-2".
Also note that if you use a source, you should not also have a resp attribute (only use resp if it's unsourced)
| <noteGrp type="abstract"> | ||
| <desc xml:lang="en">Abstract</desc> | ||
| <!-- Is there a way to add a second source for the abstract? I want to add the fact that it is one of the earliest Christian Apologies, which is mentioned in bib5502-1, but not bib5502-2. Are these composite descriptions desired?--><note corresp="http://syriaca.org/nhsl" xml:id="abstract-en-5502" source="#bib5502-2" xml:lang="en" type="abstract" resp="http://syriaca.org"> | ||
| An early Apology for Christianity originally written in Greek and addressed to an unnamed emperor (CPG 1062). |
There was a problem hiding this comment.
It's excellent that the abstract includes the CPG number. We like to capture these kinds of reference numbers (CPG, BHO, etc.) when possible. If you'd like, you can include it as an idno above under the work URI (i.e., under line 93).
It would look like: <idno type="number" subtype="CPG">1062</idno>. See https://syriaca.org/documentation/schemas/syriacaWorks.compiled.html#referenceNumbers for more on this
| <listBibl type="modernTranslations"> | ||
| <head>Modern Translations</head> | ||
| <desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl xml:id="bib5502-1" resp="http://syriaca.org" type="syriaca:ModernTranslation"> |
There was a problem hiding this comment.
It is fine, but not necessary, to include a resp on bibls
| <head>Modern Translations</head> | ||
| <desc xml:lang="en">This is not a comprehensive list of modern translations related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl xml:id="bib5502-1" resp="http://syriaca.org" type="syriaca:ModernTranslation"> | ||
| <title>The Apology of Aristides On Behalf of the Christians. From a Syriac MS. Preserved on Mount Sinai.</title> |
There was a problem hiding this comment.
Titles in listBibl/bibl should have an xml:lang attribute
| <textLang mainLang="de"/> | ||
| </bibl> | ||
| </listBibl> | ||
| <listBibl> |
There was a problem hiding this comment.
Don't forget to delete unused/empty listBibls from the template
| <head>Secondary Literature</head> | ||
| <desc xml:lang="en">This is not a comprehensive list of secondary literature related to this work. Further citations may be available through <ref target="http://syriaca.org/cbss">The Comprehensive Bibliography on Syriac Studies</ref>.</desc> | ||
| <bibl type="lawd:Citation" xml:id="bib5502-2"> | ||
| <!--not quite sure what level="a" means --><title level="a" xml:lang="en">Aristides of Athens</title> |
There was a problem hiding this comment.
the level attribute refers to whether it is an 'analytic' (i.e., journal article or book chapter), 'monographic' (level=m), or 'serial' (level=s, i.e. a book series or journal title). It's not necessary to include for these titles, especially since you have the CBSS URI in the ptr
| <bibl type="lawd:Citation" xml:id="bib5502-2"> | ||
| <!--not quite sure what level="a" means --><title level="a" xml:lang="en">Aristides of Athens</title> | ||
| <ptr target="http://syriaca.org/cbss/YIEGKM3S"/> | ||
| <citedRange unit="entry">31-32</citedRange> |
There was a problem hiding this comment.
Should this be 'entry' or 'p' for the unit?
Creating PR to give feedback to workshop participants