docs: fix nonexistent query_processed_rows metric (should be query_returned_rows)#1911
Merged
Merged
Conversation
…ry_returned_rows)
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
|
🚀 deployed to https://047c17e1.spiceai-org-website.pages.dev |
lukekim
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deployment guides across many connectors list a Spice query-execution metric named
query_processed_rowsunderruntime.metrics. No such metric exists. The runtime's query telemetry defines:query_processed_bytes(u64 counter)query_returned_bytes(u64 counter)query_returned_rows(u64 histogram) ← the actual rows metricquery_duration_ms(f64 histogram)query_failures(u64 counter; exported asquery_failures_total)Source:
crates/runtime/src/metrics/telemetry/mod.rs:59-99andcrates/runtime-metrics/src/telemetry/mod.rs:59-99(.u64_histogram("query_returned_rows")at line 85). A repo-wide grep forquery_processed_rowsreturns no instrument — the onlyprocessed_rowsmatch is the unrelateddataset_acceleration_refresh_processed_rows.This corrects
query_processed_rows→query_returned_rowseverywhere it appears.What changed
Replaced the fabricated
query_processed_rowswith the realquery_returned_rowsin all deployment/monitoring sections. Affected connectors/catalogs: s3, dremio, delta-lake, spiceai, cosmosdb, elasticsearch, github, graphql, https, duckdb, file, and the unity-catalog catalog page. Propagated across vNext + version-2.0.x + version-2.1.x (36 files).Source PRs
trunk:crates/runtime/src/metrics/telemetry/mod.rs(metric definitions).Test plan
grep -rn query_processed_rows website/→ 0 hits after fixnpm run buildnot run in this environment (no node_modules; full versioned build is memory-constrained) — CIDeploycheck is the authoritative link/tag gate for this prose-only diff.