Remove stale triage CSV worksheet references from the report (+ refresh demo report)#598
Merged
Merged
Conversation
The HTML report's Triaging guidance still told users to attach and fill out a "Triage CSV worksheet" that the scan no longer generates. Update the in-report guidance asset (2-triage-guidance.md) to ask reviewers to justify findings against the HTML report directly, and rebuild the committed Vue bundle so the generated report reflects it. Rebuilt with `npm run build` (not `just build-js`) to avoid regenerating example IAM fixtures; diff is limited to the asset and the dist bundle, no fixture drift. Mirrors the docs-site fix in #597. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Re-render index.html from the existing committed fixture and the rebuilt Vue bundle so the demo report no longer shows the stale "Triage CSV worksheet" wording. Used generate_example_report.py (not generate-report) to avoid regenerating fixtures: compare-reports confirms 0 findings added/removed, and example-iam-data.json / sampleData.js are untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kmcquade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the stale triage CSV worksheet wording from the report's in-app Triaging guidance, rebuilds the committed Vue bundle, and refreshes the demo report that embeds it.
cloudsplaining/output/src/assets/2-triage-guidance.md— the guidance source rendered in the HTML report (viaGuidance.vue). It still told users to "attach the CSV worksheet" and "fill out the Triage CSV worksheet," which the scan no longer produces. Reframed to: review the HTML report and provide a justification for each finding.cloudsplaining/output/dist/{index.html,js/index.js}— rebuilt bundle.index.html— refreshed demo report, re-rendered so it embeds the corrected bundle.This is the follow-up flagged in #597 (which fixed the docs-site copy of the same guidance).
How it was built (and why it's drift-free)
npm run builddirectly rather thanjust build-js, to skipgenerate_example_iam_data.py(which would regenerate fixtures and risk finding drift).generate_example_report.pyonly (notjust generate-report), so it re-embeds the new bundle using the existing committed fixture.Verification:
compare-reports→ 0 findings added, 0 removed;example-iam-data.json/sampleData.jsuntouched.just test-js→ 47 passing.🤖 Generated with Claude Code