Skip to content

Bugfix/rclcpp action UUID rng race condition#3183

Merged
ahcorde merged 4 commits into
ros2:rollingfrom
iv461:bugfix/rclcpp_action_uuid_rng_race_condition
Jul 7, 2026
Merged

Bugfix/rclcpp action UUID rng race condition#3183
ahcorde merged 4 commits into
ros2:rollingfrom
iv461:bugfix/rclcpp_action_uuid_rng_race_condition

Conversation

@iv461

@iv461 iv461 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #3182

Is this user-facing behavior change?

No

Did you use Generative AI?

No :)

Additional Information

Ivo Ivanov added 2 commits June 24, 2026 21:38
Fixed race condition on the RNG in rclcpp_action
c85d28e 
Signed-off-by: Ivo Ivanov <ivo.ivanov@tha.de>
The mutex should be reentrant
4ed254c 
Signed-off-by: Ivo Ivanov <ivo.ivanov@tha.de>
@mergify

mergify Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

fujitatomoya
fujitatomoya reviewed Jun 25, 2026
View reviewed changes
Comment thread rclcpp_action/src/client_base.cpp
Comment thread rclcpp_action/src/client_base.cpp Outdated
Ivo Ivanov added 2 commits June 25, 2026 12:41
Fixed compile error, the lock guard parameter needs to be of the same…
57be7db 
… type as the mutex type of course

Signed-off-by: Ivo Ivanov <ivo.ivanov@tha.de>
Changed mutex back to be non-reentrant
547b44e 
Signed-off-by: Ivo Ivanov <ivo.ivanov@tha.de>
@jmachowinski

jmachowinski commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Pulls: #3183
Gist: https://gist.githubusercontent.com/jmachowinski/2abefb9da5a9aa70bfd2dee04dcc724a/raw/9b72c3c8e10eb20ef78113fba7ed61ac8829b28e/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19708

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 569edb8 into ros2:rolling Jul 7, 2026
3 checks passed
@ahcorde

ahcorde commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

https://github.com/Mergifyio backport lyrical kilted

@mergify

mergify Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport lyrical kilted

✅ Backports have been created

Details

This was referenced Jul 7, 2026
Open
Merged
ahcorde pushed a commit that referenced this pull request Jul 8, 2026
@mergify @iv461
Bugfix/rclcpp action UUID rng race condition (#3183) (#3189)
480bc81 
(cherry picked from commit 569edb8)

Signed-off-by: Ivo Ivanov <ivo.ivanov@tha.de>
Co-authored-by: Ivo Ivanov <52303770+iv461@users.noreply.github.com>
Co-authored-by: Ivo Ivanov <ivo.ivanov@tha.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments
@jmachowinski jmachowinski jmachowinski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data race on the random number generator used in rclcpp_action for creating the UUID

4 participants

@iv461 @jmachowinski @ahcorde @fujitatomoya