Skip to content

Fix multi-seed ego_graph offset handling#5584

Open
sauravsingla wants to merge 5 commits into
rapidsai:mainfrom
sauravsingla:fix/ego-graph-multi-seed-offsets
Open

Fix multi-seed ego_graph offset handling#5584
sauravsingla wants to merge 5 commits into
rapidsai:mainfrom
sauravsingla:fix/ego-graph-multi-seed-offsets

Conversation

@sauravsingla

Copy link
Copy Markdown

Summary

This draft addresses #4191.

The lower-level pylibcugraph.ego_graph API already returns subgraph offsets for
multiple seed vertices, but the high-level Python wrapper currently discards
them.

This proposal:

  • preserves existing single-seed behavior;
  • prevents ambiguous composite output for multiple seeds;
  • exposes offsets through return_offsets=True;
  • adds regression tests covering multi-seed behavior;
  • adds weighted graph and renumbered graph coverage.

Testing

Completed without GPU:

  • Python syntax validation
  • py_compile
  • mocked wrapper control-flow tests
  • input validation tests

GPU validation is still required for:

  • cuDF integration
  • pylibcugraph execution
  • weighted graph behavior
  • renumbered graph behavior
  • SG/MG CI

This is opened as a draft to discuss the preferred public API before finalizing the implementation.

@copy-pr-bot

copy-pr-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sauravsingla sauravsingla marked this pull request as ready for review July 11, 2026 06:14
@sauravsingla sauravsingla requested a review from a team as a code owner July 11, 2026 06:14
@sauravsingla sauravsingla reopened this Jul 11, 2026
@sauravsingla

Copy link
Copy Markdown
Author

This PR was closed accidentally while I was trying to convert it to draft. The branch and commits are still available.

Could a maintainer please reopen this PR, or advise whether I should open a new draft PR from the same branch?

The change addresses #4191 and is intended for API discussion and GPU CI validation before being marked ready for review.

@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels Jul 13, 2026
@alexbarghi-nv

Copy link
Copy Markdown
Member

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

/ok to test

@alexbarghi-nv, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@alexbarghi-nv

Copy link
Copy Markdown
Member

/ok to test 62e035b

@sauravsingla

Copy link
Copy Markdown
Author

Hi @alexbarghi-nv, just checking whether the CI run for commit 62e035b needs to be retriggered. Please let me know if anything is needed from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants