class: bind inherited nams using superclass or interface reference#794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #793, the problem is that
class.togetherchanges eachclassform to define a name that is hidden by scopes, and then introduce the original name as an alias. Meanwhile, inherited fields and methods are bound using the defined class name. This commit changes inherited names and fields to be bound using the reference to a superclass or interface, instead. That avoids a problem withclass.togetherspecifically, but also seems like more the right choice in general.This is a backward-incompatible change. I'm not expecting any current programs to break, but it's possible. In particular, there could be Rhombus programs already that macro-introduce a superclass or interface reference, and this change will cause inherited field and method names to be bound as macro-introduced.