Skip to content

Remove blog posts#4676

Merged
marcoacierno merged 4 commits into
mainfrom
remove-blog
Jun 20, 2026
Merged

Remove blog posts#4676
marcoacierno merged 4 commits into
mainfrom
remove-blog

Conversation

@marcoacierno

@marcoacierno marcoacierno commented Jun 20, 2026

Copy link
Copy Markdown
Member

What

We now use Wagtail for this kind of the marketing / website content

We are keeping the DB table for now in case we need some content from it in the future

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Error Error Jun 20, 2026 4:13pm

@marcoacierno marcoacierno changed the title Remove blog post Remove blog posts Jun 20, 2026
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

This PR removes the legacy Django blog app (~554 lines deleted) since blog functionality has been superseded by the Wagtail CMS NewsArticle model. The deletion is coherent across models, admin, migrations, GraphQL schema, and settings.

Medium: demodata/blog.json not deleted
This fixture references blog.post (a now-deleted model). Any workflow that loads all files in demodata/ will raise a DeserializationError. The file should be deleted alongside the app.

Medium: No migration to drop the blog_post DB table
The PR deletes the migration history but includes no migration to actually drop the blog_post table from PostgreSQL. In all existing deployments, the table will remain as an orphan — Django will not manage it, migrate will not touch it, but it stays in the DB indefinitely. Either add a RunSQL("DROP TABLE IF EXISTS blog_post;") migration in an active app, or document this as an intentional decision.

Low: blog still listed in pyproject.toml ruff isort config
/backend/pyproject.toml:31 has "blog" in the [tool.ruff.lint.isort] known-first-party list. The module no longer exists — dead config that should be removed.

@marcoacierno

Copy link
Copy Markdown
Member Author

@claude address the review

Medium: demodata/blog.json not deleted
This fixture references blog.post (a now-deleted model). Any workflow that loads all files in demodata/ will raise a DeserializationError. The file should be deleted alongside the app.

Low: blog still listed in pyproject.toml ruff isort config
/backend/pyproject.toml:31 has "blog" in the [tool.ruff.lint.isort] known-first-party list. The module no longer exists — dead config that should be removed.

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (99de59b) to head (d23c643).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4676      +/-   ##
==========================================
- Coverage   92.52%   92.45%   -0.08%     
==========================================
  Files         359      355       -4     
  Lines       10800    10719      -81     
  Branches      821      818       -3     
==========================================
- Hits         9993     9910      -83     
- Misses        696      697       +1     
- Partials      111      112       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Claude finished @marcoacierno's task in 51s —— View job


Addressing Review Feedback

  • Delete demodata/blog.json fixture file
  • Remove blog from pyproject.toml ruff isort config
  • Commit and push changes

Both issues have been addressed in commit d23c643:

  • Deleted backend/demodata/blog.json which referenced the now-removed blog.post model
  • Removed "blog" from the known-first-party list in backend/pyproject.toml
    |

- Delete demodata/blog.json fixture that references deleted blog.post model
- Remove blog from pyproject.toml ruff isort known-first-party list

Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
@marcoacierno marcoacierno merged commit 1e28562 into main Jun 20, 2026
6 of 8 checks passed
@marcoacierno marcoacierno deleted the remove-blog branch June 20, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant