Skip to content

Fix Docker not starting locally#4673

Merged
marcoacierno merged 1 commit into
mainfrom
fix-local-start
Jun 18, 2026
Merged

Fix Docker not starting locally#4673
marcoacierno merged 1 commit into
mainfrom
fix-local-start

Conversation

@marcoacierno

Copy link
Copy Markdown
Member

What

ToDo

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Error Error Jun 18, 2026 10:22pm

@marcoacierno marcoacierno merged commit 04d3ad5 into main Jun 18, 2026
5 of 6 checks passed
@marcoacierno marcoacierno deleted the fix-local-start branch June 18, 2026 22:23
@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixes local Docker startup by moving pnpm PATH/PNPM_HOME setup from shell export statements (which die with the RUN layer) to persistent ENV directives in Dockerfile.node.local.

PNPM_HOME path doesn't match where npm install -g pnpm places the binary

npm install -g pnpm puts the pnpm executable in npm's global bin (e.g., /usr/local/bin), not in /usr/local/share/pnpm/bin. The PATH addition of /usr/local/share/pnpm/bin is inert — pnpm is found only because npm's own bin is already on PATH from the base image. The smoke-test (pnpm --version) passes for the same reason, so it doesn't validate that the new ENV PATH line is correct.

The practical risk: any future step that calls pnpm add -g and expects the resulting binary to be on PATH will silently fail.

Cleaner fix: Node 23 ships with corepack, so corepack enable pnpm (or corepack prepare pnpm@latest --activate) handles PNPM_HOME automatically and avoids this mismatch entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant