Calculate JPEG2000 total_component_width for each tile in isolation#9704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within
j2k_decode_entry,total_component_widthis initialized before the loop through tiles, and is never reset.Pillow/src/libImaging/Jpeg2KDecode.c
Line 648 in 2d18dac
Pillow/src/libImaging/Jpeg2KDecode.c
Lines 787 to 789 in 2d18dac
Pillow/src/libImaging/Jpeg2KDecode.c
Line 858 in 2d18dac
This means that the value used in
Pillow/src/libImaging/Jpeg2KDecode.c
Line 869 in 2d18dac
just keeps growing.
Instead, it should be set to zero within the tile loop, so it is only considering the current tile.