Unify StringExt#to_url and StringExt#to_permalink#232
Open
mvz wants to merge 4 commits into
Open
Conversation
mvz
commented
Jun 12, 2026
mvz
commented
Member
- Move and improve specs for StringExt#to_url
- Improve specs for StringExt#to_permalink
- Remove useless Redirect#to_url method
- Use StringExt#to_permalink exclusively
- Make StringExt#to_url an implementation detail of #to_permalink
mvz
force-pushed
the
unify-to-url-and-to-permalink
branch
from
16ee52a to
799a58d
Compare
With this change, #to_url can no longer be used.
mvz
force-pushed
the
unify-to-url-and-to-permalink
branch
from
799a58d to
07e43a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.