Fix normalize_string_prefix not lowercasing uppercase T t-string prefix#5185
Open
JSap0914 wants to merge 5 commits into
Open
Fix normalize_string_prefix not lowercasing uppercase T t-string prefix#5185JSap0914 wants to merge 5 commits into
JSap0914 wants to merge 5 commits into
Conversation
…efix T"..." t-strings added in Python 3.14 (PEP 750) were not normalized to t"..." by normalize_string_prefix. The function normalized F→f, B→b, and removed U/u, but omitted T→t when t-string support was introduced in psf#4805. This caused T"..." to pass through unchanged instead of being downcased like all other normalizable string prefixes.
| new_prefix = ( | ||
| orig_prefix.replace("F", "f") | ||
| .replace("B", "b") | ||
| .replace("T", "t") |
Collaborator
There was a problem hiding this comment.
This needs to go into the preview style.
Author
|
T→t prefix normalization is now gated behind |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
normalize_string_prefixis documented to "make all string prefixes lowercase", and it already normalisesF→fandB→b. However, when t-string support was added in #4805 theT→tnormalisation was accidentally omitted.Bug: Black leaves
T"..."unchanged instead of normalising it tot"...":Fix: Add a single
.replace("T", "t")step to the existing chain innormalize_string_prefix.Verification:
Checklist - did you ...
--previewstyle, following the stability policy?CHANGES.mdif necessary?