Design guidelines: Form and form control #5047
Open
kaylachumley wants to merge 2 commits into
Open
Conversation
Adds a new "Best practices" section with a "Menu toggles and dropdowns in a form" subsection, documenting the use of the pf-m-form modifier and its effect on border radius across themes. Includes a do/don't example image.
kaylachumley
changed the title
Collaborator
kaylachumley
requested review from
andrew-ronaldson,
bekah-stephens and
lboehling
kaylachumley
changed the title
kaylachumley
changed the title
andrew-ronaldson
requested changes
Jul 9, 2026
|  | ||
| </div> | ||
|
|
||
| In the default PatternFly theme, form elements use a square border radius. In the [Felt theme](/foundations-and-styles/theming#project-felt-theme), form elements—including input fields, menu toggles, and dropdowns—use a 6px border radius, while other non-control components use a pill radius. Using `pf-m-form` ensures that your menu toggle always matches the border radius of the surrounding form fields, regardless of theme. |
Contributor
There was a problem hiding this comment.
I'll add in the token names for the radii with the hard coded values in brackets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5052
preview for form: https://pf-org--pr-5047-site.surge.sh/components/forms/form/design-guidelines#best-practices
preview for form control: https://pf-org--pr-5047-site.surge.sh/components/forms/form-control/design-guidelines