Skip to content

test-tools: add initial version#241

Closed
bukka wants to merge 1 commit into
openssl:masterfrom
bukka:test-tools-v0-1-0
Closed

test-tools: add initial version#241
bukka wants to merge 1 commit into
openssl:masterfrom
bukka:test-tools-v0-1-0

Conversation

@bukka

@bukka bukka commented Jun 8, 2026

Copy link
Copy Markdown
Member

This adds a new Python test tool with cert setup for indirect crltest.

It allows generating certs introduced in
openssl/openssl#31244

@t8m t8m requested a review from a team June 9, 2026 06:05
Comment thread test-tools/ossl_test_tools/__main__.py Outdated
Comment thread test-tools/uv.lock
revision = 3
requires-python = ">=3.10"

[[package]]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems like it shouldn't be comitted

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is usually practice that is recommended pretty much everywhere for application - see for example https://pydevtools.com/handbook/how-to/how-to-use-a-uv-lockfile-for-reproducible-python-environments/#best-practices-for-reproducible-environments

@bukka bukka force-pushed the test-tools-v0-1-0 branch from e2d1699 to cec9ed3 Compare June 9, 2026 11:21

@Sashan Sashan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks useful. after adjusting the path in Setup section thing seems to work. thanks.

Comment thread test-tools/README.md Outdated

## Setup

cd test/pytools

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this should be

cd test-tools/
uv sync

This adds a new Python test tool with cert setup for indirect crltest.

It allows generating certs introduced in
openssl/openssl#31244
@bukka bukka force-pushed the test-tools-v0-1-0 branch from cec9ed3 to b41939e Compare June 11, 2026 20:57
@t8m

t8m commented Jun 12, 2026

Copy link
Copy Markdown
Member

As the force push does exactly what @Sashan proposed, assuming his approval.

@bukka

bukka commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

@t8m I guess this can be merged now

t8m pushed a commit that referenced this pull request Jun 16, 2026
This adds a new Python test tool with cert setup for indirect crltest.

It allows generating certs introduced in
openssl/openssl#31244

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.foundation>
MergeDate: Tue Jun 16 09:58:23 2026
(Merged from #241)
@t8m

t8m commented Jun 16, 2026

Copy link
Copy Markdown
Member

Merged. Thank you.

@t8m t8m closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants