Skip to content

Add a test for exception region#1055

Closed
mabbay wants to merge 3 commits into
openjdk:code-reflectionfrom
mabbay:exception-region-test-case
Closed

Add a test for exception region#1055
mabbay wants to merge 3 commits into
openjdk:code-reflectionfrom
mabbay:exception-region-test-case

Conversation

@mabbay

@mabbay mabbay commented Jun 5, 2026

Copy link
Copy Markdown
Member

Add a test case for when a block set itself as the handler.



Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/1055/head:pull/1055
$ git checkout pull/1055

Update a local copy of the PR:
$ git checkout pull/1055
$ git pull https://git.openjdk.org/babylon.git pull/1055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1055

View PR using the GUI difftool:
$ git pr show -t 1055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/1055.diff

Using Webrev

Link to Webrev Comment

@mabbay mabbay requested a review from PaulSandoz June 5, 2026 02:07
@mabbay mabbay self-assigned this Jun 5, 2026
@bridgekeeper

bridgekeeper Bot commented Jun 5, 2026

Copy link
Copy Markdown

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 5, 2026

Copy link
Copy Markdown

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Add a test for exception region

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2525 new commits pushed to the code-reflection branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@PaulSandoz PaulSandoz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test in a similar manner to the other tests? using a consumer to track positional state and throw depending on that state?

You would still need to use model text or build the model yourself, but you should not need to transform it.

Also this test is very similar to the one Adam added and then removed, so you could also remove Adam's test.

@mabbay

mabbay commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

/template append

@openjdk

openjdk Bot commented Jun 12, 2026

Copy link
Copy Markdown

@mabbay The pull request template has been appended to the pull request body

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 12, 2026
@mlbridge

mlbridge Bot commented Jun 12, 2026

Copy link
Copy Markdown

Webrevs

@mabbay

mabbay commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/integrate

@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

Going to push as commit 32a7df3.
Since your change was applied there have been 2526 commits pushed to the code-reflection branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jun 16, 2026
@openjdk openjdk Bot closed this Jun 16, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2026
@openjdk

openjdk Bot commented Jun 16, 2026

Copy link
Copy Markdown

@mabbay Pushed as commit 32a7df3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants