Add a test for exception region#1055
Conversation
|
👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into |
|
@mabbay This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2525 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
PaulSandoz
left a comment
There was a problem hiding this comment.
Can we test in a similar manner to the other tests? using a consumer to track positional state and throw depending on that state?
You would still need to use model text or build the model yourself, but you should not need to transform it.
Also this test is very similar to the one Adam added and then removed, so you could also remove Adam's test.
|
/template append |
|
@mabbay The pull request template has been appended to the pull request body |
Webrevs
|
|
/integrate |
|
Going to push as commit 32a7df3.
Your commit was automatically rebased without conflicts. |
Add a test case for when a block set itself as the handler.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/1055/head:pull/1055$ git checkout pull/1055Update a local copy of the PR:
$ git checkout pull/1055$ git pull https://git.openjdk.org/babylon.git pull/1055/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1055View PR using the GUI difftool:
$ git pr show -t 1055Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/1055.diff
Using Webrev
Link to Webrev Comment