chore: remove now-unused pip-compile machinery (5/5)#38839
chore: remove now-unused pip-compile machinery (5/5)#38839irfanuddinahmad wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
c79209e to
4b5c7e2
Compare
61dcf2f to
8867bc7
Compare
4b5c7e2 to
bf25c7d
Compare
8867bc7 to
9df26fe
Compare
Deletes requirements/constraints.txt, common_constraints.txt, and
pip-tools.{in,txt} -- these were kept alive through PR 2-4 because
requirements/edx-sandbox and scripts/* still pip-compiled against
them, but PR 4 was the last consumer, so they're now fully unused.
Removes the correspondingly-vestigial Makefile machinery: the
pre-requirements target, the COMMON_CONSTRAINTS_TXT curl-fetch-and-sed
target, and the CUSTOM_COMPILE_COMMAND/COMPILE_OPTS variables that only
existed to feed pip-compile invocations which no longer exist anywhere
in this repo.
Finalizes requirements/README.rst for the fully-migrated state and
fixes a couple of remaining stale references (constraints.txt ->
[tool.edx_lint].uv_constraints).
This is the last of 5 PRs migrating openedx-platform from pip-compile
to uv + PEP 621/735 pyproject.toml, tracked in
openedx/public-engineering#543. Two follow-up
items remain outside this repo's control:
- openedx/repo-tools#725: find_python_dependencies needs pyproject.toml
support before check_python_dependencies.yml can be re-enabled.
- Tutor's Dockerfile installs from requirements/edx/{base,assets,development}.txt
with plain pip; those are kept as `uv export` compatibility artifacts
(see PR 2 / #38836) rather than deleted, so no action is required there,
but tutor maintainers should be aware these are now generated files.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bf25c7d to
4730d74
Compare
9df26fe to
ea9e336
Compare
Summary
PR 5 of 5 (final) in the pip-compile -> uv migration tracked in openedx/public-engineering#543.
Stacked on #38838 (PR 4), which is stacked on #38837 -> #38836 -> #38835 — this diff only shows PR 5's own changes.
pyproject.tomldeps/dependency-groups + commituv.lockMakefile,tox.ini, and CI touvfor the main appuvprojectuvprojectsWhat changed
requirements/constraints.txt,requirements/common_constraints.txt, andrequirements/pip-tools.{in,txt}. These were deliberately kept alive through PR 2-4 (documented at the time) becauserequirements/edx-sandboxandscripts/*still pip-compiled against them — PR 4 was the last consumer, so as of that PR merging these are fully unused.pre-requirementstarget, theCOMMON_CONSTRAINTS_TXTcurl-fetch-and-sedtarget (which used to keep the localcommon_constraints.txtmirror in sync with edx-lint's upstream copy), and theCUSTOM_COMPILE_COMMAND/COMPILE_OPTSvariables that only ever fedpip-compileinvocations.requirements/README.rstfor the fully-migrated state and fixes the last couple of stale references (e.g. "pinned in constraints.txt" -> "pinned in[tool.edx_lint].uv_constraints").What's intentionally NOT done here (tracked externally)
openedx/repo-tools#725:find_python_dependenciesneedspyproject.tomlsupport beforecheck_python_dependencies.yml(disabled in PR 2) can be re-enabled.requirements/edx/{base,assets,development}.txtwith plainpip. Those are kept asuv exportcompatibility artifacts (PR 2) rather than deleted, so no action is required on tutor's side right now — but tutor maintainers should be aware these paths are now machine-generated, not hand-compiled.Verification
make compile-requirementsre-run end-to-end (root project + all 4 uv sub-projects) inside anubuntu:24.04container after removing the vestigial Makefile machinery — completes cleanly with zeropip-compile/pip-toolsinvocations anywhere.pip-compile/pip-sync/requirements/edx/(the deleted directory) confirms only intentional historical-context comments remain (e.g. explaining what a path used to point to), no functional references.🤖 Generated with Claude Code