Skip to content

[Backport] feat: add ora reminder notification#38828

Open
AhtishamShahid wants to merge 1 commit into
openedx:release/verawoodfrom
AhtishamShahid:ahtisham/backport-ora-reminder-verawood
Open

[Backport] feat: add ora reminder notification#38828
AhtishamShahid wants to merge 1 commit into
openedx:release/verawoodfrom
AhtishamShahid:ahtisham/backport-ora-reminder-verawood

Conversation

@AhtishamShahid

Copy link
Copy Markdown
Contributor

Backport

Backport of #38298 (commit 6ec5d41) to release/verawood.

Cherry-picked cleanly with no conflicts.

Description

Introduces a new notification type ora_reminder for Open Response Assessment (ORA) reminders, ensuring learners are notified about pending self or peer review steps.

  • Added a new notification type ora_reminder to the NotificationType dictionary (grading app), with web and email channels enabled, daily email cadence, and a content template for pending ORA steps.
  • Mapped the ora_reminder notification type to its icon in the notification icon mapping.
  • Updated test_views.py test data for notification settings and non-editable preferences.
  • Bumped ora2 from 7.0.0 to 7.1.0 (the version that ships the ORA reminder sweeper).

Depends on edx-ora2 ≥ 7.1.0 (openedx/edx-ora2#2389).

Original PR

#38298

* feat: added ora reminder notification
Copilot AI review requested due to automatic review settings June 30, 2026 11:58
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 30, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @AhtishamShahid!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports support for a new ora_reminder notification type so learners can be reminded about pending ORA self/peer review steps, and updates the ORA dependency to a version that includes the reminder sweeper.

Changes:

  • Add ora_reminder to the notifications registry (enabled for web + email, daily cadence) with a content template/context.
  • Add an icon mapping for the new notification type.
  • Update notification preference aggregation tests and bump ora2 to 7.1.0 across compiled requirement sets.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
requirements/edx/base.txt Bumps ora2 to 7.1.0 in the base lockfile.
requirements/edx/development.txt Propagates the ora2==7.1.0 bump into the dev lockfile.
requirements/edx/doc.txt Propagates the ora2==7.1.0 bump into the docs lockfile.
requirements/edx/testing.txt Propagates the ora2==7.1.0 bump into the testing lockfile.
openedx/core/djangoapps/notifications/base_notification.py Registers the new ora_reminder notification type and its templates.
openedx/core/djangoapps/notifications/email/notification_icons.py Maps ora_reminder to the ORA icon.
openedx/core/djangoapps/notifications/tests/test_views.py Extends expected notification preference payloads to include ora_reminder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openedx/core/djangoapps/notifications/base_notification.py
@ayub02 ayub02 requested a review from feanil June 30, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants