feat: add tests for password reset functionality for retired users#38737
Merged
Conversation
ttak-apphelix
approved these changes
Jun 16, 2026
robrap
reviewed
Jun 16, 2026
ktyagiapphelix2u
force-pushed
the
ktyagi/BOMS-626
branch
from
fccec9c to
d70afb7
Compare
robrap
reviewed
Jun 22, 2026
robrap
reviewed
Jun 29, 2026
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
The following are very minor comments, and we can merge shortly. It don't think it needs to go through another round of internal review, but whatever you want.
| # Always return 200 OK to prevent user enumeration while leaving the password unchanged and unusable. | ||
| assert response.status_code == 200 | ||
| self.user.refresh_from_db() | ||
| assert not self.user.has_usable_password() |
Contributor
There was a problem hiding this comment.
Would it make sense to add assert not self.user.is_active here, and add this assertions above, to simply show that there is no change to any of the assertions? The last assertion here probably isn't needed above, because you're copying out the password there.
Contributor
Author
There was a problem hiding this comment.
sounds resonable proving nothing changed is the whole point of these tests.
robrap
reviewed
Jul 1, 2026
robrap
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses follow-up feedback from PR #38427 by replacing the retirement TODO with a permanent comment explaining why social accounts are retained during the cooling-off period, and by adding tests to verify that retired users cannot initiate or complete password reset flows.
Private Ticket
https://2u-internal.atlassian.net/browse/BOMS-626