[Diagram Editor] Enhance compatibility hint with inference#210
Open
ArizmendiWan wants to merge 16 commits into
Open
[Diagram Editor] Enhance compatibility hint with inference#210ArizmendiWan wants to merge 16 commits into
ArizmendiWan wants to merge 16 commits into
Conversation
…gram editor. Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
…onnections between handles of the same type. Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
aaronchongth
requested changes
Jul 6, 2026
aaronchongth
left a comment
aaronchongth
left a comment
Member
There was a problem hiding this comment.
Thanks for handling this feature! I've left some comments, mostly related to the frontend. Overall I've not seen any issues from the usability side,
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
mxgrey
reviewed
Jul 7, 2026
aaronchongth
previously approved these changes
Jul 8, 2026
Member
There was a problem hiding this comment.
LGTM on the changes for the frontend
Should wait till @mxgrey's review has been addressed before merging
Signed-off-by: ArizmendiWan <2311602492@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets issue #172 and issue #203.
This PR adds compatibility checks for diagram editor connections while preserving incomplete-diagram editing workflows. The editor now:
Compatibility works in two layers:
The editor first rejects impossible connections locally: output-to-output, input-to-input, etc.
For a valid-looking candidate, the frontend builds an in-memory diagram with the proposed edge added, then calls
checkCompatibility. Rust runs editor-only inference on the focused ports for that candidate.compatible: the editor may allow the connection.incompatible: proven invalid, such as hard compile/layout errors or message type mismatch.unknown: API/system failure or unsafe-to-classify error.provisional: true when inference needs more graph context, for example buffer/listen/join cases where the type cannot be determined yet.ScriptMessageconversion. If inference cannot determine types only because context is missing, the result becomes provisionally compatible, but final compile/run can still reject it later.01.mov
02.mov
03.mov
GenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: Codex