[seekdb][ddl] Fix DDL lock timeout propagation#968
Open
hnwyllmm wants to merge 1 commit into
Open
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Online ALTER TABLE operations could cause client requests to wait indefinitely when they conflicted with concurrent online DDL locks. This occurred because the DDL lock layer passed
timeout_us = 0to table lock requests. However, the table lock code interprets0with mixed semantics: sometimes as a try-lock, and in other code paths, it expands to the table-lock service's default timeout, leading to unbounded waits.Solution Description
The fix ensures the DDL lock request uses a bounded timeout. It propagates the current worker's remaining timeout to the DDL lock request, using
_ob_ddl_timeoutas a fallback when the worker has no deadline. This prevents passingtimeout_us = 0into table lock requests, thereby bounding the DDL lock wait by the active DDL request's timeout. Additionally, the errorOB_ERR_EXCLUSIVE_LOCK_CONFLICTis now classified as a retryable table-lock error for DDL normalization paths.Passed Regressions
git diff --check
Upgrade Compatibility
No upgrade compatibility impact. The change only affects DDL lock wait timeout propagation and retry error normalization.
Other Information
issue.mdand2are not included in the MR.Release Note
Fixed an issue where online ALTER TABLE operations could wait indefinitely due to DDL lock timeout mispropagation. DDL lock waits are now correctly bounded by the request's timeout.