fix: prevent visual clipping of irregular WeekRange tooltip #4414
fix: prevent visual clipping of irregular WeekRange tooltip #4414javieryeow wants to merge 4 commits into
Conversation
|
@javieryeow is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts how the timetable’s interactive tooltip is mounted so it renders at the document root of the reference element (rather than inside the local container), likely to avoid clipping/stacking issues.
Changes:
- Add an
appendTohandler to mount the tooltip under the reference element’sownerDocumentroot. - Introduce a helper function (
mountToReferenceRoot) used by the tooltip.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4414 +/- ##
==========================================
+ Coverage 54.52% 56.40% +1.87%
==========================================
Files 274 317 +43
Lines 6076 6964 +888
Branches 1455 1680 +225
==========================================
+ Hits 3313 3928 +615
- Misses 2763 3036 +273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@greptile |
|
Context
closes #4385
irregular WeekRange tooltip in timetable cells was cut off visually, likely due to "interactive" property which made it mount into the reference's parent container. This caused the tooltip to get clipped off at the container boundary instead of just floating freely.
Implementation
fixed the clipping issue by mounting the tooltip to the reference element's ownerDocument root, so that it renders outside the timetable's container, preventing it from being cut off by overflow.
Other Information