feat: add timeout parameter to Client HTTP requests#259
Open
Flerpharos wants to merge 1 commit into
Open
Conversation
Client HTTP requests (raw_api_get, raw_api_post, stream_api_get, stream_api_post) previously omitted a timeout argument, defaulting to None (blocking indefinitely). This could cause the caller to hang if the TCP connection stalled or the server accepted the connection but never responded. Add a configurable 'timeout' parameter to Client.__init__ (default 60.0s) and pass it down to all requests.Session.get and post calls. Closes #212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client HTTP requests (
raw_api_get,raw_api_post,stream_api_get,stream_api_post) previously omitted atimeoutargument, defaulting toNone(blocking indefinitely). This could cause the caller to hang if the TCP connection stalled or the server accepted the connection but never responded.Fix
Add a configurable
timeoutparameter toClient.__init__(default 60.0s) and pass it down to allrequests.Session.getandpostcalls.Closes #212