refactor: replaced signalStore() overloads with a generic#5166
Closed
KratosAurion1 wants to merge 1 commit into
Closed
refactor: replaced signalStore() overloads with a generic#5166KratosAurion1 wants to merge 1 commit into
KratosAurion1 wants to merge 1 commit into
Conversation
Contributor
|
I am going to close that one. We don't have an issue with that, so it doesn't follow the contribution guidelines. Apart from that, we have so many overloads because each You should also check the build locally first. The PR doesn't even compile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
signalStore() has multiple semi-redundant overloads
Closes #
What is the new behavior?
signalStore() has a single signature
Does this PR introduce a breaking change?
Other information