Skip to content

refactor: replaced signalStore() overloads with a generic#5166

Closed
KratosAurion1 wants to merge 1 commit into
ngrx:mainfrom
KratosAurion1:signalStore_TS_notation
Closed

refactor: replaced signalStore() overloads with a generic#5166
KratosAurion1 wants to merge 1 commit into
ngrx:mainfrom
KratosAurion1:signalStore_TS_notation

Conversation

@KratosAurion1

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

signalStore() has multiple semi-redundant overloads

Closes #

What is the new behavior?

signalStore() has a single signature

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

@rainerhahnekamp

Copy link
Copy Markdown
Contributor

I am going to close that one. We don't have an issue with that, so it doesn't follow the contribution guidelines.

Apart from that, we have so many overloads because each SignalStoreFeature needs to infer the exact type of its previous ones.

You should also check the build locally first. The PR doesn't even compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants