feat(tray): Add user status and more items to the tray's user menu#10164
feat(tray): Add user status and more items to the tray's user menu#10164Rello wants to merge 1 commit into
Conversation
Signed-off-by: Rello <github@scherello.de>
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ed407314d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _setUserStatusOperations.push_back(SetUserStatusOperation::Message); | ||
| _userStatusConnector->setUserStatus(_userStatus); |
There was a problem hiding this comment.
With the new status window using finishOnOnlineStatusSet: false, a user can change the online state and immediately click “Set status message” before the connector's online/message jobs from the status change finish. OcsUserStatusConnector::setUserStatus() returns early while a set job is already running, but this code still queues a Message operation; when the earlier status-change completion arrives, the model pops that queued Message and emits finished, closing the window even though the new message was never sent. Please serialize/disable the save until the prior request completes, or only queue the operation when the connector accepts it.
Useful? React with 👍 / 👎.
|
|
Artifact containing the AppImage: nextcloud-appimage-pr-10164.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
1 participant
Tray Menu:
New Windows: