test: Add failing harness tests for AE resetting to max ISO on session start#4015
Open
stevengoldberg wants to merge 1 commit into
Open
test: Add failing harness tests for AE resetting to max ISO on session start#4015stevengoldberg wants to merge 1 commit into
stevengoldberg wants to merge 1 commit into
Conversation
|
@stevengoldberg is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
18 tasks
Owner
|
Thanks! PR triggered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two failing harness tests to
visioncamera.controller.harness.tsreproducing a v5 regression: everyCameraSession.start()resets auto-exposure to the format's max ISO, so the first ~600–900 ms of preview are massively overexposed while AE visibly ramps back down. v4 and the native camera app show correctly exposed frames immediately.The two tests
keeps an exposure lock applied between configure() and start()— deterministic and scene-independent. Locks exposure to a mid-range ISO / short duration afterconfigure()but beforestart(), then asserts the lock survivesstart(). Todaystart()clobbers the lock:exposureModeresets to continuous auto-exposure andisojumps to the format's max.resumes auto-exposure near previously converged values on a fresh session— the user-facing symptom. Lets AE converge in a first session, stops it, starts a second session on the same device, and asserts the first readable ISO is within 4x of the converged value. Today the second session restarts at max ISO (~50x above a typical indoor converged value). The test skips itself when the scene is so dark that converged ISO is near max (e.g. taped-over Device Farm cameras), since the regression would be indistinguishable from correct convergence there.Observed telemetry (iPhone, indoor scene, RNVC 5.0.11)
This happens on every
start(), including when theAVCaptureDevicestill holds the previously converged exposure values, and even when an explicitsetExposureLocked(...)was applied betweenconfigure()andstart().Expected
start()should leave the device's exposure state alone (or at minimum honor an explicit lock), matching v4 andAVCaptureSessionbehavior in a plain native app, where the first rendered frames are already correctly exposed.