fix: Seed metering state from current device state#3979
Open
mrousavy wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Seed each iOS MeteringTask state from the current
AVCaptureDevice.isAdjusting...value immediately after installing the KVO observer.Why
KVO is still used for transitions, but if AVFoundation decides no adjustment is needed and the
isAdjusting...value remainsfalse, there may be no transition to observe. Seeding the current value lets that no-op case enter the normal 120ms settled window instead of waiting until the hard timeout.This PR is intentionally isolated from the observer-order, timeout, KVO queue, and cleanup PRs so CI behavior can be compared independently.
Validation
git diff --check