fix(publish,demo): align media constraints#2181
Merged
Merged
Conversation
…buffer bar Three unrelated demo fixes: - The console overlay printed err.stack, but JavaScriptCore and SpiderMonkey build the stack as a bare frame list with no leading 'Name: message' line, so on Safari and Firefox the only part that identifies the error (the code in 'RESET_STREAM: 24') was dropped. Prepend the header when the stack does not already carry it, keyed on the stack contents rather than the browser, so V8 does not print it twice. - The watch tile's active-state effect both wrote watch.muted and read the catalog for the speaker badge, so every catalog frame re-ran it and re-asserted muted=false, reverting the user's speaker-mute a moment after each click. Split the badge into its own effect. - The buffer-bar canvas could not shrink inside its flex row (min-width: 0). Also expose the microphone's echoCancellation/autoGainControl/noiseSuppression constraints and the camera resolution request in the publish demo, since the macOS defaults engage the system voice processor: auto gain slowly rides the capture level down and other system audio is ducked while the mic is live.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
kixelated
reviewed
Jul 12, 2026
kixelated
reviewed
Jul 12, 2026
kixelated
reviewed
Jul 12, 2026
Co-authored-by: GPT-5 <codex@openai.com>
Co-authored-by: GPT-5 <codex@openai.com>
Co-authored-by: GPT-5 <codex@openai.com>
kixelated
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #2163.
Summary:
echoCancellation,autoGainControl, andnoiseSuppressionwhile keeping Auto as the browser default.width.max * height.maxas themaxPixelsfallback when both constraints are present andconfig.maxPixelsis unset.Public API changes:
EncoderConfig.maxPixelsnow documents and uses sourcewidth.maxandheight.maxas a fallback cap when both are present.Branch targeting:
main. The branch is based ondev; retargeting tomainwould include unrelateddevchanges, so this PR remains ondev.Test plan:
nix develop --command env CARGO_TARGET_DIR=/Users/kixelated/.codex/worktrees/078c/moq/target just checknix develop --command just js checkCheckis green.(Written by GPT-5)