Stop suppressing MYMETA so installers can discover our prerequisites#7
Open
melo wants to merge 1 commit into
Open
Stop suppressing MYMETA so installers can discover our prerequisites#7melo wants to merge 1 commit into
melo wants to merge 1 commit into
Conversation
Setting NO_MYMETA => 1 prevented `perl Makefile.PL` from writing MYMETA.json/MYMETA.yml. Installers such as App::cpm (cpm) and App::cpanminus (cpanm) discover a distribution's prerequisites from the MYMETA produced by the configure step, not from the static META.json in the tarball. As a result, whenever Markdown::Perl was pulled in as a dependency (for example a cpanfile with `requires 'Markdown::Perl'` when generating a cpanfile.snapshot), cpm saw it as having no dependencies and silently omitted all of its runtime prerequisites (Unicode::CaseFold, Encode::Locale, List::MoreUtils, YAML::Tiny, Readonly). Removing NO_MYMETA restores MYMETA generation. We keep dynamic_config => 0 since our prerequisites are declared statically in the cpanfile; the generated META.json/META.yml content is unchanged. MANIFEST.SKIP and .gitignore are updated so the regenerated MYMETA files never leak into git or the distribution tarball. Note: Makefile.PL is generated from the perl_setup_dist (Dist::Setup) template, so the same fix should be applied upstream in Dist::Setup to prevent it being reintroduced on the next regeneration.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting NO_MYMETA => 1 prevented
perl Makefile.PLfrom writing MYMETA.json/MYMETA.yml. Installers such as App::cpm (cpm) and App::cpanminus (cpanm) discover a distribution's prerequisites from the MYMETA produced by the configure step, not from the static META.json in the tarball. As a result, whenever Markdown::Perl was pulled in as a dependency (for example a cpanfile withrequires 'Markdown::Perl'when generating a cpanfile.snapshot), cpm saw it as having no dependencies and silently omitted all of its runtime prerequisites (Unicode::CaseFold, Encode::Locale, List::MoreUtils, YAML::Tiny, Readonly).Removing NO_MYMETA restores MYMETA generation. We keep dynamic_config => 0 since our prerequisites are declared statically in the cpanfile; the generated META.json/META.yml content is unchanged. MANIFEST.SKIP and .gitignore are updated so the regenerated MYMETA files never leak into git or the distribution tarball.
Note: Makefile.PL is generated from the perl_setup_dist (Dist::Setup) template, so the same fix should be applied upstream in Dist::Setup to prevent it being reintroduced on the next regeneration.