Add expander groups to settings UI#20200
Open
carlos-zamora wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carlos-zamora
commented
May 8, 2026
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Feels overloaded and unstructured. I think normal headings would be better. And for an easy access the expanders should be opened by default if you wil go with expanders. |
carlos-zamora
force-pushed
the
dev/cazamor/sui-rejuv/expander-groups
branch
from
7fed067 to
d865073
Compare
carlos-zamora
changed the base branch from
main
to
dev/cazamor/sui-rejuv/setting-container
Member
Author
Demo
|
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Much better after the last changes 🔥🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds expander groups throughout the entire settings UI (except Profiles pages) to group similar settings together. These expanders got an icon to help make them easier to find and navigate.
There are also a few other changes that were folded into this PR:
Those were done as a part of this PR for a holistic restructuring. Given that spacing has changed, the content also needs to be reviewed so that it looks right with this new structure (i.e. long help text should be reconsidered to be shorter).
Validation Steps Performed
Scenarios:
PR Checklist
Related to #17000