Guard large-head nonpad Attention MEA dispatch#29140
Open
Kevin-Li-2025 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kevin-Li-2025 <2242139@qq.com>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28388.
The ONNX Attention CUDA path currently allows Memory Efficient Attention for the
nonpad_kv_seqlenexternal-cache path with large head sizes. That path uses the CUTLASS custom right-padding variant, which can exceed the dynamic shared-memory opt-in limit on smaller architectures forhead_size > 256and crash instead of falling back.This keeps MEA available for the normal path, but makes
nonpad_kv_seqlen != nullptr && head_size > 256fall through to the unified unfused path, which already supports large head sizes.Tests
python3 -m py_compile onnxruntime/test/python/transformers/test_onnx_attention/test_gqa.pygit diff --checkI also attempted the targeted pytest locally:
python3 -m pytest -q onnxruntime/test/python/transformers/test_onnx_attention/test_gqa.py -k large_head_nonpad_seqlen_falls_back_from_mea_fp16but local collection is blocked by a missing
parameterizedpackage before reaching ORT/CUDA execution.