Replace PropTypes usage with deprecated-react-native-prop-types#1004
Open
ingointo wants to merge 1 commit into
Open
Replace PropTypes usage with deprecated-react-native-prop-types#1004ingointo wants to merge 1 commit into
ingointo wants to merge 1 commit into
Conversation
Author
|
hey.. |
|
hi, some news about this PR? |
mujahid033
approved these changes
Feb 22, 2024
mujahidGW
approved these changes
Feb 22, 2024
Author
Hello MaiconLeffa, I appreciate your patience. I've thoroughly tested the changes and addressed any feedback received. The pull request is still in progress, and I'll continue to keep you updated on any further developments. Please feel free to reach out if you have any specific questions or concerns. Thank you once again for your interest and support! |
mujahidGW
approved these changes
Feb 26, 2024
mujahid033
approved these changes
Feb 26, 2024
Pandazaur
approved these changes
Mar 13, 2024
|
hello,When will the merger begin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
None, this PR addresses a deprecation warning related to the use of
PropTypes.What does this PR do?
This PR updates the codebase to replace the usage of
PropTypeswith thedeprecated-react-native-prop-typespackage. The goal is to resolve the deprecation warning related toViewPropTypesand align with the recommended migration away fromPropTypesin React Native.What testing has been done on this change?
This change has been tested locally to ensure that the deprecation warning no longer occurs. Additionally, the application has been tested to verify that the functionality of the
react-native-snap-carousellibrary remains unaffected.Tested features checklist
enableMomentum)vertical)activeSlideAlignment)autoplay)loop)ScrollView/FlatListcarousels (propuseScrollView)ParallaxImagecomponentPaginationcomponentAdditional Notes
Ensure that the changes do not introduce any regressions and that the library's features remain fully functional.
This PR is in response to the deprecation warning mentioned here. The replacement of
PropTypesis a step toward compatibility with the evolving standards in React Native.Please review and provide feedback. Thank you!