Clarify limitations of Element.checkVisibility()#44443
Merged
Merged
Conversation
github-actions
Bot
added
Content:WebAPI
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-06-16 02:08:14) |
hamishwillee
approved these changes
Jun 16, 2026
hamishwillee
left a comment
hamishwillee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks very much @tim-we
Contributor
Author
|
@hamishwillee thanks for the review. I think some minor mistakes snuck in the changes, I opened up a follow up PR here: #44492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to make the limitations of
checkVisibilitymore obvious. For example when an element is occluded thecheckVisibilitymethod may still returntrue.Motivation
The current version claims this:
while the spec uses more careful wording:
I think this is slightly misleading as there are many cases in which an element is not visible to the user but this method still returns true. Even with all the optional checks enabled.
Additional details
Specification
Related issues and pull requests
No related PRs or issues.