Skip to content

Preserve literal static attributes when folding #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshhanley wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserve literal static attributes when folding #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Parser/Attribute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ public function getStaticValue(): mixed
throw new \LogicException("Cannot get static value of dynamic attribute '{$this->name}'.");
}

if ($this->valueless) {
return true;
}

if (! $this->bound()) {
return $this->value;
}

return match ($this->value) {
'true' => true,
'false' => false,
Expand Down
9 changes: 8 additions & 1 deletion tests/ComparisonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@
['readonly' => false],
));

test('foldable literal string attributes matching PHP constants', fn () => compare(<<<'BLADE'
<x-foldable.input value="true" />
<x-foldable.input value="false" />
<x-foldable.input value="null" />
BLADE
));

test('same component in a slot doesnt affect parents attributes', fn () => compare(<<<'BLADE'
<x-card>
<x-card x-data>
Expand Down Expand Up @@ -115,4 +122,4 @@
</x-wrapper>
</x-card>
BLADE
));
));
Loading