fix(voice): honor agent preemptive generation options#1796
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
fix(voice): honor agent preemptive generation options#1796rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Ported from livekit/agents#6114
Original PR description
Closes #6112.
preemptive_generationwas read directly fromsession.options, so an agent'sturn_handling={"preemptive_generation": {...}}had no effect — the session value (defaultenabled: True) always won. This is inconsistent withendpointing, which already resolves agent-over-session viaendpointing_opts.This adds a
preemptive_generation_optsproperty onAgentActivitythat merges the agent's keys over the fully-resolved session value, and routes both call sites (on_preemptive_generationand the preemptive-TTS branch inpipeline_reply) through it.Note this only fixes the effective behavior. The session report (
make_session_report) still reflects session-level options only, so it won't show per-agent overrides; that reporting gap is tracked separately.