fix(voice): add transcript segment close timeout#1777
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
fix(voice): add transcript segment close timeout#1777rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b96534c The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
toubatbrian
reviewed
Jun 16, 2026
Comment on lines
+556
to
+568
|
|
||
| const timedOut = Symbol('timedOut'); | ||
| let timeout: ReturnType<typeof setTimeout> | undefined; | ||
| const result = await Promise.race([ | ||
| this.captureTask, | ||
| new Promise<typeof timedOut>((resolve) => { | ||
| timeout = setTimeout(() => resolve(timedOut), SEGMENT_CLOSE_TIMEOUT); | ||
| }), | ||
| ]).finally(() => clearTimeout(timeout)); | ||
|
|
||
| if (result === timedOut) { | ||
| this.logger.warn('SegmentSynchronizerImpl.close timed out draining capture task'); | ||
| } |
Contributor
There was a problem hiding this comment.
We have
/**
* Race a promise against an idle timeout. If the promise does not settle within
* `timeoutMs` milliseconds, the returned promise rejects with {@link IdleTimeoutError}
* (or the error returned by `throwError` when provided).
* The timer is properly cleaned up on settlement to avoid leaking handles.
*/
export function waitUntilTimeout<T, E extends Error = IdleTimeoutError>(
promise: Promise<T>,
timeoutMs: number,
throwError?: () => E,
): Promise<Throws<T, E | IdleTimeoutError>> {
let timer: ReturnType<typeof setTimeout> | undefined;
return ThrowsPromise.race([
promise,
new ThrowsPromise<never, E | IdleTimeoutError>((_, reject) => {
timer = setTimeout(() => reject(throwError?.() ?? new IdleTimeoutError()), timeoutMs);
}),
]).finally(() => clearTimeout(timer)) as Promise<Throws<T, E>>;
}
in utils.ts. Can we use this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of livekit/agents#6029.
Testing
Ported from livekit/agents#6029
Original PR description
_SegmentSynchronizerImpl.aclose()awaits the forwarding/speaking-rate tasks unconditionally. If a downstream output stalls, those awaits can hang and block segment rotation from installing a fresh impl, leavingTranscriptSynchronizer._implstuck closed.Add a timeout fallback: if the tasks don't drain in time, warn and cancel them so rotation always completes. Also stamp each impl with an id and include it in the warning extras, so a stuck impl can be told apart from a fresh one in logs.