Add Polygon/Polyhedron NSIDED/NFACED ExodusII output#4490
Add Polygon/Polyhedron NSIDED/NFACED ExodusII output#4490ConnorOuellette wants to merge 5 commits into
Conversation
roystgnr
left a comment
There was a problem hiding this comment.
I'd have split this into like 6 commits instead of 2 (re-bootstrap should be separate, tests could be separate, additional build_cube option should be separate), but the contents look mostly solid. That hardcoded block id (unless I'm just misunderstanding?) is the only thing that looks wrong.
| int num_face_blk; | ||
| int num_face; |
There was a problem hiding this comment.
These additions look like The Right Way To Do It to me, but I'll want to give @jwpeterson time to chime in before merging; IIRC the ExodusHeaderInfo refactor was an addition of his for Akselos usage.
|
Looks like you turned on some auto-code-reformatting option in your editor? That works within MOOSE, so long as you're pointing clang-format to the MOOSE config file and you're using the right clang-format version, but libMesh doesn't use the same (or any clang-format config-describable) formatting standards, and auto-reformatting utterly wrecked your ff02c5c commit. I can't find the needle of the actual changes in the 4000-line haystack of the reformatting. As a general safety rule, never |
Summary
This adds ExodusII output support for libMesh’s arbitrary polygon and polyhedron elements:
C0POLYGONelements as ExodusNSIDEDblocksC0POLYHEDRONelements as ExodusNFACEDblocksNFACEDoutputNotes