crl/storer: Include issuerNameID in CRL upload logs#8845
Merged
Conversation
The crl-updater attaches issuerNameID to all its log lines (added during #8606 review), but the storer's "CRL uploaded" line carried only the issuer CN. Since the S3 object key is {nameID}/{shardIdx}.crl, tying an upload log line to its object required an out-of-band CN to NameID mapping. Log the NameID too.
beautifulentropy
changed the title
ezekiel
approved these changes
Jul 6, 2026
aarongable
approved these changes
Jul 6, 2026
Contributor
|
This was a purposeful omission, as I think we're now in a place where we could move away from IssuerNameID if we wanted to. But it's still useful to log here, as the S3 upload path includes the IssuerNameID, so restoring it makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crl-updater attaches issuerNameID to all its log lines (added during #8606 review), but the storer's "CRL uploaded" line carried only the issuer CN. Since the S3 object key is {nameID}/{shardIdx}.crl, tying an upload log line to its object required an out-of-band CN to NameID mapping. Log the NameID too.
This PR was generated as part of an audit of #8606 using Claude Fable 5.